Repository navigation
Accept LicenseRef exceptions in ParseSyntax - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change adding syntax-only support for LicenseRef-* exception identifiers.
No open issues 🎉
What changed in this PR
Updates ParseSyntax to accept well-formed LicenseRef-* exception identifiers after WITH, addressing ScanCode compatibility in issue #36 while preserving strict parsing behavior.
Changes:
- Accept and validate exception references, preserving their text in
License.Exception. - Document the compatibility behavior.
- Add regression coverage for malformed references, compound expressions, identifier rewriting, and strict-parser rejection.
| File | Description |
|---|---|
parse.go |
Accepts and validates exception references in syntax-only parsing and documents support. |
parse_syntax_test.go |
Tests reference acceptance, rejection, AST preservation, and rewriting. |
Review effort: Balanced
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseSyntaxrejects ScanCode exception identifiers such asGPL-2.0-only WITH LicenseRef-scancode-cygwin-exception-2.0before checking their syntax.Accept well-formed
LicenseRef-*identifiers afterWITHinParseSyntaxfor ScanCode compatibility. Preserve the identifier inLicense.Exceptionand keep strict parsing unchanged. Add regression coverage for reference syntax, compound expressions and identifier rewriting.Closes #36