Skip to content

test(e2e): Fix failing e2e tests after db span name adjustments #23971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 1 commit into from
Sep 2, 2026
+4 −7
Merged

test(e2e): Fix failing e2e tests after db span name adjustments #23971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dev-packages/e2e-tests/test-applications/nextjs-16/tests/db-page.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ test('Instruments DB calls made during server-side rendering of a page', async (

// One page render produces spans from both injection paths: pg (externalized → runtime module
// hook) and ioredis (bundle-safe allowlisted → build-time loader).
// The postgres span name is low cardinality under span streaming (just the operation); the query
// itself is asserted below via `db.query.text`. The redis span names still carry their full text.
expect(spans).toContainEqual(
expect.objectContaining({
name: 'SELECT',
Expand All @@ -31,7 +29,7 @@ test('Instruments DB calls made during server-side rendering of a page', async (
);
expect(spans).toContainEqual(
expect.objectContaining({
name: 'set page-key [1 other arguments]',
name: 'set localhost:6379',
status: 'ok',
attributes: expect.objectContaining({
'sentry.op': { value: 'db.query', type: 'string' },
Expand All @@ -44,7 +42,7 @@ test('Instruments DB calls made during server-side rendering of a page', async (
);
expect(spans).toContainEqual(
expect.objectContaining({
name: 'get page-key',
name: 'get localhost:6379',
status: 'ok',
attributes: expect.objectContaining({
'sentry.op': { value: 'db.query', type: 'string' },
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/solidstart/instrument.server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import * as Sentry from '@sentry/solidstart';

Sentry.init({
traceLifecycle: 'static',
dsn: process.env.E2E_TEST_DSN,
environment: 'qa', // dynamic sampling bias to keep transactions
tracesSampleRate: 1.0, // Capture 100% of the transactions
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/solidstart/tests/db.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test('Instruments ioredis automatically via build-time orchestrion', async ({ ba
expect(redisSpans).toHaveLength(2);
expect(redisSpans).toContainEqual(
expect.objectContaining({
name: 'set test-key [1 other arguments]',
name: 'set localhost:6379',
status: 'ok',
attributes: expect.objectContaining({
'sentry.op': { type: 'string', value: 'db.query' },
Expand All @@ -41,7 +41,7 @@ test('Instruments ioredis automatically via build-time orchestrion', async ({ ba
);
expect(redisSpans).toContainEqual(
expect.objectContaining({
name: 'get test-key',
name: 'get localhost:6379',
status: 'ok',
attributes: expect.objectContaining({
'sentry.op': { type: 'string', value: 'db.query' },
Expand Down
Loading