test(e2e): Fix failing e2e tests after db span name adjustments - #23971
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we ran into some timing issues with merging PRs. #23741 changed redis span names to be low cardinality when span streaming is enabled, and some e2e tests were converted to span streaming at the same time. However, the e2e tests didn't take these changes into account.
Partially my bad because I wasn't aware that we test redis spans in so many e2e tests. Good to have them though!
Partially ... merge queues?