Skip to content

fix(security): avoid loading secrets in config report - #94

Merged
gabrielvfonseca merged 2 commits into
mainfrom
fix/redact-config-report
Oct 21, 2026
Merged

gabrielvfonseca merged 2 commits into
mainfrom
fix/redact-config-report

Conversation

@gabrielvfonseca

Copy link
Copy Markdown
Contributor

Summary

  • inspect config metadata without constructing the credential-bearing runtime configuration for text /config output
  • preserve loaded-file, merged-key, and section presence/status reporting
  • keep sensitive telemetry/config values out of human-readable output

Verification

  • cargo fmt --all
  • cargo test -p cli --bin code (149 passed)
  • cargo test -p cli --test output_format_contract config_telemetry_emits_structured_json_when_requested
  • cargo test -p cli --test resume_slash_commands resumed_config_command_loads_settings_files_end_to_end
  • git diff --check

This is the follow-up for the remaining Rust cleartext-logging alert after #90.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ce5558c-a5a1-48cd-b732-c30cdca92883
📥 Commits

Reviewing files that changed from the base of the PR and between 59d074d and b36a82b.

📒 Files selected for processing: 1
  • cli/src/main.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gabrielvfonseca
gabrielvfonseca merged commit fafc979 into main Oct 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant