Repository navigation
build!: require Java 11 - #461
Merged
Merged
Conversation
All modules compile at release 11 in one pass, without the second pass that compiled the classes for Java 8. ClientFuture overrides newIncompleteFuture as an ordinary override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release 11in one pass. The second pass that compiled the classes for Java 8 is gone, andwebrtc-javafxno longer needs a compiler setup of its own.ClientFuture.newIncompleteFutureis an ordinary override, so futures derived from those of the client API refuse blocking waits on every supported Java.java.net.http.HttpClient, which needs it.