Repository navigation
fix: send WHIP/WHEP requests with HttpClient, bounded and apart from peer control - #462
Merged
Merged
Conversation
…peer control POST and DELETE ran on the control pool, so a slow server held up the control tasks of other peers, and only each read of a response was bounded. They now go through java.net.http.HttpClient and hold no thread while they wait. The session's timeout bounds a request as a whole, and the session's deadline or a cancellation cuts off a request still out. The offer follows 307 and 308 redirects, as RFC 9725 requires.
devopvoid
force-pushed
the
fix/whip-whep-http-client
branch
from
October 27, 2026 17:09
61b3291 to
178d95f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.net.http.HttpClientand hold no thread while they wait.HttpClient: no SOCKS proxies; proxy credentials only as Basic, and only for sessions without a bearer token, sinceHttpClientdrops the token once it answers for credentials. Ending a request that still waits for its head needs Java 16; before, it ends with its timeout.