Repository navigation
test(e2e): real-backend first-run journey, real-shape a11y fixtures, and fixes it found - #183
Merged
Merged
Conversation
…tegy Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Nine declarative manifests (Anymail Finder, Bouncer, MillionVerifier, Findymail, ContactOut) with docs-derived fixtures and one generic test, a wiring test across catalog, workbook and settings registries, and a rewritten manifest format guide. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Replace every native confirm/prompt with useConfirm()/usePrompt() (focus managed, destructive style, named objects). Fix target-size at shared level via --gtm-target-min (accounts for the shell's CSS zoom), fix contrast and unnamed controls, add six routes to the axe gate, and empty the baseline. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ls; changelog for the Go cutover Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…_verify words response.value_maps translates a mapped value with an explicit default, request.omit_empty drops empty headers, query parameters and body keys, and values substituted into request.url are escaped. The three verifier manifests now emit only valid, invalid, catch_all, risky, unknown. Adds Settings key cards for LeadMagic and Prospeo. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Audience and automation delivery adds a lead to a HeyReach (LinkedIn) or lemlist (email) campaign with the workspace's own API key. Workbook output columns are not part of this change. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ints Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Upserts each member as an Attio person matched on email and links or creates its company by domain, with the workspace's own token. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nto train/2026-11-19
…o train/2026-11-19
… train/2026-11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…rain/2026-11-19 # Conflicts: # apps/web/src/components/command-menu-content.tsx
Drives the built app against a running stack (setup, Get started, sample run, every route in light and dark, one action per area), records API statuses, console output and error states, and writes screenshots and findings.json. Separate config and script; not part of test:a11y and not run in CI. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nalytics trend contrast The mocked suite answered unmatched endpoints with [], so /overview, /analytics and /settings rendered their error states (or a skeleton) and were never audited with content. Add shapes captured from the real API, fail any page that shows an error state, and wait for the query retry before auditing. The analytics page, now rendered with data, exposed low-contrast trend text (emerald-500 and red-400 on white); use the 700/400 pair. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Loading the sample completes step 3, and done steps carry no actions, so Open it from step 3 pointed at nothing. The workbook link is step 4's. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
The list search cast accepted_fields to text, so domain or name (or any short term) matched every record. Search the values with jsonb_each_text. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
|
All contributors on this pull request have signed the OpenGTM CLA. Thank you! Agreement: OpenGTM CLA 1.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #175 (the combined train branch
train/2026-11-19). Merge #175 first, or retarget after it lands.Why
Every web test so far ran against a mocked API. This drives the real UI against the real Go backend (nginx, api-go, Postgres, worker) as a new user would, and compares what the real API returns with the a11y fixtures.
What changed
apps/web/e2e/real/first-run.spec.ts, its ownplaywright.config.tsand a README, run withbun run test:e2e-realagainst a stack named byOPENGTM_E2E_BASE_URL. Not part oftest:a11y, not in PR CI. It does first-run setup, the Get started checklist (sample workbook, real run, polls state), every sidebar and admin route in light and dark (API status, console, error states, screenshot), and one action per area. Writes screenshots andfindings.json.fixtures/real-shapes.tswith shapes captured from the real API (records summary, analytics, settings providers, destinations, outreach, ...). The suite now fails a page that shows "temporarily unavailable", "returned an invalid response" or "could not be verified", and waits for the query retry (1s) before auditing; previously a failing query was audited as a skeleton.GET /api/records/summaryhad no fixture, so the mock answered[]andparseRecordOverviewrejected it. The real body is an object with the seven counts,workbooks[],imports[],sampled_at, and the real page renders fine on it.accepted_fieldsto text, sodomain,nameorsmatched every record (31 of 31 in the journey). It now searches values withjsonb_each_text. Integration test added.Findings not fixed (bug reports)
no_data, 25no_answer(no AI provider configured);/api/workbooks/{id}statusfailed, 25/25 rows; overview shows a red Failed badge and "1 failed workbook"; the workbook shows "Run needs attention: Some work failed". Expected: a run that finishes with empty provider results is complete, and the missing AI provider is named. Cause:apps/backend-go/internal/workbook/run.gofinalize (res.Errors > 0givesfailed), andcell.go~846 storesno_dataas statuserror. Bigger than one file; product decision needed.apps/web/src/pages/analytics.tsxand the/api/analytics/*handlers (leads table).login.tsx:85fetcheshttps://api.github.com/repos/...from the browser on the setup/login page. A self-hosted app calling a third party on first load; unauthenticated GitHub rate-limits (one run logged a 403 console error). Needs a decision (remove, or proxy and cache).%and_as wildcards (not escaped in the ILIKE). Not changed here.Expected, not bugs
-default.How it was tested
opengtm-e2e, ports 23480-23483, subnet 10.177.43.0/24, rehearsal override),bun run test:e2e-real: passed, 891/apiand/authcalls, 887 x 200 and 4 x 201, no 4xx or 5xx, no page errors. Setup, sample load, real run (settled atfailed 25/25, see 1), 21 routes x 2 themes, and all 7 actions (company, audience from filter, webhook dialog cancel, template workbook, Pipeline setting, command palette, 5-row CSV import with results).bun run lint: clean.bun test tests: 204 pass.bun run build: ok.bun run test:a11y: 52 pass (one earlier run had a single mount timeout on /chat mobile under load; the rerun passed). Removing the summary fixture makes the new guard fail /overview.go test -tags integration ./internal/recordsagainst the stack's own Postgres: ok (398s). The new test fails without the fix.Not tested