Repository navigation
fix: no third-party requests on page view; literal % and _ in searches - #184
Merged
Merged
Conversation
…tegy Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Nine declarative manifests (Anymail Finder, Bouncer, MillionVerifier, Findymail, ContactOut) with docs-derived fixtures and one generic test, a wiring test across catalog, workbook and settings registries, and a rewritten manifest format guide. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Replace every native confirm/prompt with useConfirm()/usePrompt() (focus managed, destructive style, named objects). Fix target-size at shared level via --gtm-target-min (accounts for the shell's CSS zoom), fix contrast and unnamed controls, add six routes to the axe gate, and empty the baseline. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ls; changelog for the Go cutover Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…_verify words response.value_maps translates a mapped value with an explicit default, request.omit_empty drops empty headers, query parameters and body keys, and values substituted into request.url are escaped. The three verifier manifests now emit only valid, invalid, catch_all, risky, unknown. Adds Settings key cards for LeadMagic and Prospeo. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Audience and automation delivery adds a lead to a HeyReach (LinkedIn) or lemlist (email) campaign with the workspace's own API key. Workbook output columns are not part of this change. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ints Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Upserts each member as an Attio person matched on email and links or creates its company by domain, with the workspace's own token. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nto train/2026-11-19
…o train/2026-11-19
… train/2026-11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…rain/2026-11-19 # Conflicts: # apps/web/src/components/command-menu-content.tsx
Drives the built app against a running stack (setup, Get started, sample run, every route in light and dark, one action per area), records API statuses, console output and error states, and writes screenshots and findings.json. Separate config and script; not part of test:a11y and not run in CI. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nalytics trend contrast The mocked suite answered unmatched endpoints with [], so /overview, /analytics and /settings rendered their error states (or a skeleton) and were never audited with content. Add shapes captured from the real API, fail any page that shows an error state, and wait for the query retry before auditing. The analytics page, now rendered with data, exposed low-contrast trend text (emerald-500 and red-400 on white); use the 700/400 pair. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Loading the sample completes step 3, and done steps carry no actions, so Open it from step 3 pointed at nothing. The workbook link is step 4's. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
The list search cast accepted_fields to text, so domain or name (or any short term) matched every record. Search the values with jsonb_each_text. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Removed the GitHub star-count fetch from the login page (plain link stays), replaced Google favicon requests with local icons or initials in the workbook, legacy leads, lead detail and quick look, and made the lead-detail map (Nominatim geocoding and OpenStreetMap tiles) load only after a click. The a11y suite now fails any route, and /login, that requests another origin. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Add internal/sqllike (Escape, Contains) and use it for the record search and the workbook row query; the lead list and read queries (sqlc) get the same escaping in SQL, as emaildata already had. A lone % used to match every row. The two recorded lead vectors that relied on wildcard semantics (specialization IT_Staffing and %) now expect literal matches. All other ILIKE/LIKE uses are fixed patterns. Every query built from request input is parameterised; the few concatenated identifiers (leads update columns, record table names) come from allow-lists. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
|
All contributors on this pull request have signed the OpenGTM CLA. Thank you! Agreement: OpenGTM CLA 1.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #183 (real-backend journey and fixes). Merge #183 first.
1. No third-party requests on page view
Requests from the web app to a non-relative origin, found by grepping
apps/web/src,index.htmlandpublic:pages/login.tsxapi.github.com/repos/...(star count)pages/workbook-editor.tsx,pages/leads.tsxgoogle.com/s2/favicons?domain=per rowpages/lead-detail.tsx,components/quick-look/quick-look.tsxpages/lead-detail.tsxnominatim.openstreetmap.orggeocoding andtile.openstreetmap.orgtilescomponents/markdown-content.tsx, quick-look image<img>isSafeImageSrcandsafeUrlalready block non-same-origin images<a href="https://...">links (GitHub, OpenStreetMap, a lead's website, the login page credits)public/source-logos/manifest.jsonFonts are bundled;
index.htmlloads only local scripts. The events stream and workbook socket are same-origin.a11y gate:
installMocksnow records any request to an origin other than the page's own; every covered route and a new/logintest fail if there is one. Before the change the/logintest failed onapi.github.com; after, all 53 a11y tests pass.2. Literal % and _ in search terms
internal/sqllike(Escape,Contains) used by the record search (records/store.go, nowILIKE $3 ESCAPE '\', parameterised) and the workbook row query (wbcrud, which already escaped with/, now through the same helper).leads_list.sqlandleads_read.sql(search and specialization filters, 17 ILIKEs) escape in SQL, the wayemaildata.sqlalready did;sqlc generatere-run.LIKE/ILIKEin the Go backend: the other uses are fixed patterns (%@gmail.com,watch:%:pollnow:and similar).wbcrud/leadupdate.go,leadswrite,collect/bulk.go), fixed table names (records,watchsvc,audiencerefresh) and a validated role name (migrate). I found nothing that is not parameterised.specialization=IT_Staffingand%, 20 cases intestdata/leads_vectors.json) relied on wildcard matching. Their expected results now reflect literal matching (%matches nothing;IT_Staffingmatches the one row that has it). The generator inlegacy/pythonwould produce the old values if re-run.Tests
go test ./internal/sqllike ./internal/wbcrud: ok.go test -tags integration ./internal/leadsread ./internal/records ./internal/wbcrud ./internal/audiencevalidagainst my own Postgres (the opengtm-e2e compose project): all ok. New cases:%,_,\, andstr%e/s_ripematch nothing,50%_omatches the one stored value containing it (records and leads).bun run lint,bun test tests(204),bun run build,bun run test:a11y(53): pass.Not tested