Repository navigation
fix(assistant): the CurveBender notice shows in Dammy's chat, and the greeting names no provider - #6700
Merged
Conversation
… greeting names no provider #6461 kept the notice off the assistant's own chat and off every account it onboarded, because the greeting named the provider there instead. That greeting sentence is gone, so the notice is the one place a new person learns what their assistant runs on, and it now follows the rule every Agent's chat follows. - The notice has one audience again: a chat that does not exist yet, on an install whose shared Connection the person holds, once the pair has settled. - The greeting loses its CurveBender sentence and keeps the design's line about where the provider is changed, which renders for every provider rather than as the alternative to CurveBender's. - An account's cohort is no longer read or written. The column stays, because v0.3.0 ships it and a rollback to that release reads it. - The chat no longer reads the assistant record, so the settledness rule and the record's read for a person the feature is off for are gone with it. Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
There was a problem hiding this comment.
🛡️ Code Guardian 🛡️ — ✅ Code Review @ 2b4b09a
PR #6700: fix(assistant): the CurveBender notice shows in Dammy's chat, and the greeting names no provider
Author: JanPokorny | Branch: fix/curvebender-notice-in-dammy-chat → main | Changes: +68 −594 (27 files)
Summary
This PR removes the provider sentence from Dammy's greeting and drops the assistant and cohort exceptions from the CurveBender notice. It keeps dambledore_provisioned.legacy in the database schema for rollback safety while removing all runtime reads and writes.
Limits: 2 skill(s) did not run: issue-fit, review-guide.
Findings
- ✅ Looks good:
dambledore_provisioned.legacyremains inpackages/db/src/schema.tswithdefault(false), so rollbacks tov0.3.0still read a valid column.
Documentation Check (doc-drift)
✅ No findings.
TypeScript Engineering Review
✅ No findings.
React UI Engineering Review
✅ No findings.
Verdict
APPROVE — All greeting, notice, repository, and documentation changes are consistent and verified.
Review by Code Guardian 🛡️ · automated code guardian · ibm/gcp/gemini-4-argon on pi
JanPokorny
added a commit
that referenced
this pull request
Nov 18, 2026
… greeting names no provider (#6700) The CurveBender notice is the info box above a new chat's composer. #6461 kept it out of the assistant's own chat, and out of every account the platform onboarded with the assistant, because the greeting named CurveBender instead. The greeting no longer names a provider. So the notice is now the only place a new person learns what their assistant runs on. It shows in Dammy's chat like in any other Agent's chat. ## Reviewer guide **What changes in substance** - **The notice has one audience again.** A chat that does not exist yet, on an install whose shared Connection the person holds, once the chat's pair has settled. The two #6461 exclusions are gone, and nothing replaces them: no chat and no account is special. - **The greeting keeps the half that renders for everyone.** The CurveBender sentence went. `You can switch providers anytime in Agent settings.` stays, because it renders today whatever the provider is — the CurveBender sentence was the conditional addition, not its alternative. - **An account's cohort is no longer read or written.** `legacy` leaves the api-server's answer, the repository and the create. The column stays in `packages/db/src/schema.ts` (see **The cohort column**). - **The notice no longer reads the assistant record.** The settledness rule (`assistantAudienceKnown`) and the un-gated `trpc.assistants.state` read existed only for it, so both go and the query is skipped again for a person the feature is off for. **Where to look closely** - `packages/ui/src/modules/sessions/lib/curve-bender.ts` — the decision is now three inputs. A wrong answer here shows an offer to a chat that is already on CurveBender, which is the flash the settledness rule was written for; the pair, not the assistant record, is what settles it. - `packages/api-server-api/src/modules/assistants/greeting.ts` — the instructions written into a new assistant's `~/AGENTS.md`. They must describe the greeting as it now reads, or a new assistant narrates a line that is not on the screen. - `packages/db/src/schema.ts` — a column nobody uses. It is deliberate (below), and the next migration generator must not read it as drift. **Ruled out** - Removing the whole provider line. The settings half renders for every provider today, so the non-CurveBender case is its own, not a leftover of the CurveBender sentence. - Dropping the column in this change. `v0.3.0` is in production and reads it, so a drop would break a rollback to that release. - Keeping the assistant record in the notice's inputs and ignoring it. A read with no reader is the cost #6461 added; it goes with the rule. **Gates you changed** - `packages/ui/src/__tests__/unit/curve-bender-notice.test.ts` — the assistant cases ("never shows in the assistant's own chat", "shows nothing to an account onboarded with the assistant", "is about the record, not about having one", "waits for the record") are deleted, because the inputs they pass no longer exist. The four audience cases remain. - `packages/ui/src/__tests__/unit/assistant-greeting.test.ts` — "names the provider it has, and no other" and "reads the provider from provider Connections alone" are deleted with the functions they test. - `packages/ui/src/__tests__/unit/assistant-audience.test.ts` — deleted with `assistantAudienceKnown`. - `packages/api-server/src/__tests__/unit/assistant-provisioning.test.ts` — the "the account's cohort, decided once" block is deleted. Its "makes one Agent at the first admitted request" case now asserts the greeting line the instructions describe, instead of the provider sentence. - `packages/api-server/src/__tests__/unit/dambledore-legacy-migration.test.ts` — deleted. The migration stays, and the column it adds has no behaviour left to test. - `packages/ui/src/__tests__/unit/assistant-greeting.test.ts` gains "points at Agent settings and names no provider", which fails if the provider sentence comes back. **Who decided** - Removing the cohort exception as well, so the notice has one rule (the person's instruction, through the task). - (open) Keeping `You can switch providers anytime in Agent settings.` rather than the whole provider line. - (open) Leaving the column and deleting its migration's test. - (open) Restoring the `enabled: useAssistantOn()` gate on the assistant record read. ## The cohort column `dambledore_provisioned.legacy` (migration `0142_dambledore_legacy`) now has no reader and no writer. It stays because `v0.3.0` ships and reads it: dropping it would make a rollback to that release fail on a missing column. Rows keep the value they were given, and a new row takes the default. A follow-up can drop it once no supported release reads it, with its own migration. ## What an existing assistant still believes The platform writes `~/AGENTS.md` once, at the create, and never rewrites it. So an assistant made before this change still carries: *The provider line under it names the model provider you run on only when the person's own provider Connection is CurveBender's, and otherwise says where they change it.* That is wrong now: the greeting names no provider. Its new chats also show the notice, which says what it runs on, so the person is not left without the answer. The `dam` skill is the one channel that reaches an assistant made earlier, and `skills/dam/references/personal-assistant.md` gains one line saying its greeting names no provider, in the same place it already tells the assistant to prefer the skill's copy of the rules. ## Issue No issue tracks this change. Issue #5690's AC-2 says the greeting shows "a line saying it runs on CurveBender". This change removes that line, so the AC no longer matches the product. The issue is not edited here; the person should update AC-2, or say that the notice is what satisfies it. ## Screenshots None, with the reason the repository's web-UI proof rule allows: this machine has no local cluster to bring the app up on, and standing one up is a full `cluster:install`, not a cheap headless run. Even then it would prove only half the change: a local install sets no shared CurveBender key, so the notice cannot appear there at all — the same limit #6461 hit, which shipped one negative shot and tests. To see both halves, on an install whose chart sets `apiServer.curveBenderDeployment.apiKey`: 1. Sign in as a fresh account. The platform makes Dammy, and the first open lands in its chat. 2. Dammy's new chat shows the greeting — `Hi <name>! I'm Dammy, your personal DAM agent. You can switch providers anytime in Agent settings.` — and, above the composer, the notice in the **set up** variant. 3. `Use a different provider` opens the pair picker, and `✕` hides the notice alone. 4. Send a message, then open a new chat on Dammy: the greeting is gone and the notice is still there. 5. The same chat on an account that had Agents before Dammy looks the same, which #6461 made impossible. ## Testing - `mise run //packages/ui:check` — passes. - `mise run //packages/ui:test` — 341 files, 2265 tests pass. - `mise run //packages/api-server:check` — passes. - `mise run //packages/api-server:test` — 4700 tests pass. - `mise run check` — passes, in the commit hook. - `mise run check:comment-types` — passes. - Not run: any turn on a real install. The internal model endpoints do not resolve from this machine, and no cluster is up. <!-- author-decisions summary: The person asked that the CurveBender notice stop hiding in Dammy's chat, and that the greeting lose the CurveBender line that made the notice redundant there. The cohort exception went with it, so the notice has one rule again. - The CurveBender notice shows in the assistant's own chat, like in any other Agent's chat | scope: packages/ui/src/modules/sessions/lib/curve-bender.ts — the notice's audience | why: the person asked that it stop being hidden there | 2026-11-18 - The cohort exception goes too, so no account is judged and the notice has one audience rule | scope: packages/ui/src/modules/sessions/lib/curve-bender.ts, packages/api-server/src/modules/assistants/services/assistants-service.ts — the recorded cohort | why: with the greeting's line gone the notice is the only place a new person learns their assistant runs on CurveBender | 2026-11-18 --> Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> (cherry picked from commit f67d626)
JanPokorny
added a commit
that referenced
this pull request
Nov 18, 2026
The greeting kept the design's "You can switch providers anytime in Agent settings." after the CurveBender sentence went (#6700). The person asked for that too, so the greeting is now the opening and the learning line, and the CurveBender notice above the composer is the only place that says what the assistant runs on. - `ASSISTANT_SETTINGS_SENTENCE`, `ASSISTANT_SETTINGS_LINK`, the greeting's settings link, its `settingsPrefix`/`settingsLink` and the `Agent settings` button leave the greeting, in the UI and in the `~/AGENTS.md` instructions. - The `dam` skill's line for an assistant made earlier covers both halves. - Docs and the QA profile stop naming the greeting as a way into Agent settings. Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> (cherry picked from commit 5eccdfeec7a240ac5cd13094785aea686720283f)
JanPokorny
added a commit
that referenced
this pull request
Nov 18, 2026
Dammy's greeting names no model provider any more. The previous change (#6700) removed the CurveBender sentence and kept `You can switch providers anytime in Agent settings.` The person asked for that line too, so the greeting is now the opening and the learning line and nothing else, and the CurveBender notice above the composer is the only place that says what the assistant runs on. ## Reviewer guide **What changes in substance** - **The greeting has no provider line at all.** `ASSISTANT_SETTINGS_SENTENCE` and `ASSISTANT_SETTINGS_LINK` go, with the `Agent settings` button they rendered and the two fields the UI copy carried. Nothing replaces them: the greeting says `Hi <name>! I'm <assistant>`, then that it learns how the person works. - **The instructions in a new assistant's `~/AGENTS.md` lose the same line**, so a new assistant describes the greeting as it now reads. An assistant made earlier keeps what it was given; the `dam` skill's personal-assistant page now covers both halves in one sentence, and it is rewritten at every upgrade. - **The greeting is no longer a way into Agent settings.** Its name row still opens that dialog, so the docs and the QA profile that listed the greeting's link now name the row. **Where to look closely** - `packages/ui/src/modules/assistants/components/assistant-greeting.tsx` — the paragraph is now one interpolation. `onConfigure` stays because the name row uses it; dropping it there would take the dialog away from the greeting entirely. - `packages/api-server-api/src/modules/assistants/greeting.ts` — the `~/AGENTS.md` template. It must not leave a dangling line where the sentence was. **Ruled out** - Keeping the sentence as the greeting's only provider mention. It is the last provider text there, and the notice already says where to change the provider. **Gates you changed** - `packages/ui/src/__tests__/unit/assistant-greeting.test.ts` — "points at Agent settings in the design's words" is deleted with the fields it asserted; "points at Agent settings and names no provider" becomes "names no provider and no place to change it", which fails if any part of the line returns. - `packages/api-server/src/__tests__/unit/assistant-provisioning.test.ts` — the instructions case now asserts neither "switch providers" nor "Agent settings" appears, instead of asserting the sentence. **Who decided** - Dropping the sentence as well (the person's instruction). - (open) Nothing else: the change is a deletion, and the notice's own copy is untouched. ## The release line carries this too `release-v0.3.1` holds the same change as **`e4cbb2956`**, a cherry-pick of the first commit here (`5eccdfeec`), and is tagged `v0.3.1-rc.2`. The two patches differ only where the release line has no such file: `docs/architecture/chat-view.md` (`DU` in the cherry-pick — the page does not exist at `v0.3.0`), and the `chat-view.tsx` comment that listed the greeting's link, which that line never had. ## Issue No issue tracks this change. ## Screenshots None: this machine has no local cluster to bring the UI up on, and standing one up is a full `cluster:install`, not a cheap headless run. The greeting is now `Hi <name>! I'm Dammy, your personal DAM agent.` followed by the learning line; the unit tests assert its rendered text. ## Testing - `mise run //packages/ui:check` — passes. - `mise run //packages/ui:test` — 341 files, 2265 tests pass. - `mise run //packages/api-server:check` — passes. - `mise run //packages/api-server:test` — 4700 tests pass. - `mise run check` — passes, in the commit hook. - `mise run check:comment-types` — passes. - On `release-v0.3.1`, after the cherry-pick: UI check and 2161 tests, api-server check and 4685 tests. <!-- author-decisions summary: The person asked that the greeting lose its last provider sentence too, so it has no provider line at all. The same change goes to main and into the 0.3.1 hotfix as one patch. - The greeting keeps no provider line, not even where to change the provider | scope: packages/api-server-api/src/modules/assistants/greeting.ts, packages/ui/src/modules/assistants/ — the greeting's text | why: the person asked for the sentence to go as well | 2026-11-18 --> Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CurveBender notice is the info box above a new chat's composer.
#6461 kept it out of the assistant's own chat, and out of every account the platform onboarded with the assistant, because the greeting named CurveBender instead.
The greeting no longer names a provider.
So the notice is now the only place a new person learns what their assistant runs on.
It shows in Dammy's chat like in any other Agent's chat.
Reviewer guide
What changes in substance
The two fix(ui): the CurveBender notice keeps off Dammy's chat and accounts onboarded with it #6461 exclusions are gone, and nothing replaces them: no chat and no account is special.
You can switch providers anytime in Agent settings.stays, because it renders today whatever the provider is — the CurveBender sentence was the conditional addition, not its alternative.legacyleaves the api-server's answer, the repository and the create.The column stays in
packages/db/src/schema.ts(see The cohort column).assistantAudienceKnown) and the un-gatedtrpc.assistants.stateread existed only for it, so both go and the query is skipped again for a person the feature is off for.Where to look closely
packages/ui/src/modules/sessions/lib/curve-bender.ts— the decision is now three inputs.A wrong answer here shows an offer to a chat that is already on CurveBender, which is the flash the settledness rule was written for; the pair, not the assistant record, is what settles it.
packages/api-server-api/src/modules/assistants/greeting.ts— the instructions written into a new assistant's~/AGENTS.md.They must describe the greeting as it now reads, or a new assistant narrates a line that is not on the screen.
packages/db/src/schema.ts— a column nobody uses.It is deliberate (below), and the next migration generator must not read it as drift.
Ruled out
v0.3.0is in production and reads it, so a drop would break a rollback to that release.Gates you changed
packages/ui/src/__tests__/unit/curve-bender-notice.test.ts— the assistant cases ("never shows in the assistant's own chat", "shows nothing to an account onboarded with the assistant", "is about the record, not about having one", "waits for the record") are deleted, because the inputs they pass no longer exist. The four audience cases remain.packages/ui/src/__tests__/unit/assistant-greeting.test.ts— "names the provider it has, and no other" and "reads the provider from provider Connections alone" are deleted with the functions they test.packages/ui/src/__tests__/unit/assistant-audience.test.ts— deleted withassistantAudienceKnown.packages/api-server/src/__tests__/unit/assistant-provisioning.test.ts— the "the account's cohort, decided once" block is deleted. Its "makes one Agent at the first admitted request" case now asserts the greeting line the instructions describe, instead of the provider sentence.packages/api-server/src/__tests__/unit/dambledore-legacy-migration.test.ts— deleted. The migration stays, and the column it adds has no behaviour left to test.packages/ui/src/__tests__/unit/assistant-greeting.test.tsgains "points at Agent settings and names no provider", which fails if the provider sentence comes back.Who decided
You can switch providers anytime in Agent settings.rather than the whole provider line.enabled: useAssistantOn()gate on the assistant record read.The cohort column
dambledore_provisioned.legacy(migration0142_dambledore_legacy) now has no reader and no writer.It stays because
v0.3.0ships and reads it: dropping it would make a rollback to that release fail on a missing column.Rows keep the value they were given, and a new row takes the default.
A follow-up can drop it once no supported release reads it, with its own migration.
What an existing assistant still believes
The platform writes
~/AGENTS.mdonce, at the create, and never rewrites it.So an assistant made before this change still carries: The provider line under it names the model provider you run on only when the person's own provider Connection is CurveBender's, and otherwise says where they change it.
That is wrong now: the greeting names no provider.
Its new chats also show the notice, which says what it runs on, so the person is not left without the answer.
The
damskill is the one channel that reaches an assistant made earlier, andskills/dam/references/personal-assistant.mdgains one line saying its greeting names no provider, in the same place it already tells the assistant to prefer the skill's copy of the rules.Issue
No issue tracks this change.
Issue #5690's AC-2 says the greeting shows "a line saying it runs on CurveBender". This change removes that line, so the AC no longer matches the product.
The issue is not edited here; the person should update AC-2, or say that the notice is what satisfies it.
Screenshots
None, with the reason the repository's web-UI proof rule allows: this machine has no local cluster to bring the app up on, and standing one up is a full
cluster:install, not a cheap headless run.Even then it would prove only half the change: a local install sets no shared CurveBender key, so the notice cannot appear there at all — the same limit #6461 hit, which shipped one negative shot and tests.
To see both halves, on an install whose chart sets
apiServer.curveBenderDeployment.apiKey:Hi <name>! I'm Dammy, your personal DAM agent. You can switch providers anytime in Agent settings.— and, above the composer, the notice in the set up variant.Use a different provideropens the pair picker, and✕hides the notice alone.Testing
mise run //packages/ui:check— passes.mise run //packages/ui:test— 341 files, 2265 tests pass.mise run //packages/api-server:check— passes.mise run //packages/api-server:test— 4700 tests pass.mise run check— passes, in the commit hook.mise run check:comment-types— passes.