Skip to content

fix(assistant): Dammy's greeting has no provider line - #6705

Merged
JanPokorny merged 1 commit into
mainfrom
fix/dammy-greeting-no-provider-line
Nov 18, 2026
Merged

JanPokorny merged 1 commit into
mainfrom
fix/dammy-greeting-no-provider-line

Conversation

@JanPokorny

Copy link
Copy Markdown
Contributor

Dammy's greeting names no model provider any more.
The previous change (#6700) removed the CurveBender sentence and kept You can switch providers anytime in Agent settings.
The person asked for that line too, so the greeting is now the opening and the learning line and nothing else, and the CurveBender notice above the composer is the only place that says what the assistant runs on.

Reviewer guide

What changes in substance

  • The greeting has no provider line at all. ASSISTANT_SETTINGS_SENTENCE and ASSISTANT_SETTINGS_LINK go, with the Agent settings button they rendered and the two fields the UI copy carried.
    Nothing replaces them: the greeting says Hi <name>! I'm <assistant>, then that it learns how the person works.
  • The instructions in a new assistant's ~/AGENTS.md lose the same line, so a new assistant describes the greeting as it now reads.
    An assistant made earlier keeps what it was given; the dam skill's personal-assistant page now covers both halves in one sentence, and it is rewritten at every upgrade.
  • The greeting is no longer a way into Agent settings. Its name row still opens that dialog, so the docs and the QA profile that listed the greeting's link now name the row.

Where to look closely

  • packages/ui/src/modules/assistants/components/assistant-greeting.tsx — the paragraph is now one interpolation.
    onConfigure stays because the name row uses it; dropping it there would take the dialog away from the greeting entirely.
  • packages/api-server-api/src/modules/assistants/greeting.ts — the ~/AGENTS.md template.
    It must not leave a dangling line where the sentence was.

Ruled out

  • Keeping the sentence as the greeting's only provider mention. It is the last provider text there, and the notice already says where to change the provider.

Gates you changed

  • packages/ui/src/__tests__/unit/assistant-greeting.test.ts — "points at Agent settings in the design's words" is deleted with the fields it asserted; "points at Agent settings and names no provider" becomes "names no provider and no place to change it", which fails if any part of the line returns.
  • packages/api-server/src/__tests__/unit/assistant-provisioning.test.ts — the instructions case now asserts neither "switch providers" nor "Agent settings" appears, instead of asserting the sentence.

Who decided

  • Dropping the sentence as well (the person's instruction).
  • (open) Nothing else: the change is a deletion, and the notice's own copy is untouched.

The release line carries this too

release-v0.3.1 holds the same change as e4cbb2956, a cherry-pick of the first commit here (5eccdfeec), and is tagged v0.3.1-rc.2.
The two patches differ only where the release line has no such file: docs/architecture/chat-view.md (DU in the cherry-pick — the page does not exist at v0.3.0), and the chat-view.tsx comment that listed the greeting's link, which that line never had.

Issue

No issue tracks this change.

Screenshots

None: this machine has no local cluster to bring the UI up on, and standing one up is a full cluster:install, not a cheap headless run.
The greeting is now Hi <name>! I'm Dammy, your personal DAM agent. followed by the learning line; the unit tests assert its rendered text.

Testing

  • mise run //packages/ui:check — passes.
  • mise run //packages/ui:test — 341 files, 2265 tests pass.
  • mise run //packages/api-server:check — passes.
  • mise run //packages/api-server:test — 4700 tests pass.
  • mise run check — passes, in the commit hook.
  • mise run check:comment-types — passes.
  • On release-v0.3.1, after the cherry-pick: UI check and 2161 tests, api-server check and 4685 tests.

The greeting kept the design's "You can switch providers anytime in Agent
settings." after the CurveBender sentence went (#6700). The person asked for
that too, so the greeting is now the opening and the learning line, and the
CurveBender notice above the composer is the only place that says what the
assistant runs on.

- `ASSISTANT_SETTINGS_SENTENCE`, `ASSISTANT_SETTINGS_LINK`, the greeting's
  settings link, its `settingsPrefix`/`settingsLink` and the `Agent settings`
  button leave the greeting, in the UI and in the `~/AGENTS.md` instructions.
- The `dam` skill's line for an assistant made earlier covers both halves.
- Docs and the QA profile stop naming the greeting as a way into Agent settings.

Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
@JanPokorny JanPokorny added the code-guardian:review Add this label to trigger an automatic review by code-guardian. label Nov 18, 2026

@dam-code-protector dam-code-protector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Code Guardian 🛡️ — ✅ Code Review @ 38e2126

PR #6705: fix(assistant): Dammy's greeting has no provider line

Author: JanPokorny | Branch: fix/dammy-greeting-no-provider-line → main | Changes: +24 −62 (13 files)

Summary

This pull request removes the Agent settings provider line from the assistant greeting across the UI, instructions, and docs.

Limits: 1 skill(s) did not run: issue-fit.

Findings

  • 🟢 Suggestion: Settings modal entry-point lists omit the assistant greeting's name (docs/architecture/chat-view.md:29, packages/ui/src/modules/sessions/views/chat-view.tsx:834).
  • ✅ Looks good: AssistantGreeting keeps onConfigure on SpeakerRow, and skills/dam/references/personal-assistant.md updates older assistants at upgrade time.

Documentation Check (doc-drift)

  • 🟢 Suggestion: docs/architecture/chat-view.md changes in this pull request, but its Last verified: header stays 2026-11-17 instead of 2026-11-18 (docs/architecture/chat-view.md:3).

TypeScript Engineering Review

✅ No findings.

React UI Engineering Review

✅ No findings.

Verdict

APPROVE — The greeting removes the provider sentence cleanly across the UI, standing instructions, skill text, and unit tests.


Review by Code Guardian 🛡️ · automated code guardian · ibm/gcp/gemini-4-argon on pi

The Agent's settings are a modal, and only a modal: there is no settings page beside it.
The modal is the app's own, mounted beside its other overlays, so every wrench, *Agent settings*, opens it wherever the person is: a sidebar row's and a Home agent card's, as the chat's agent menu does; so do every prompt and notice that sends a person to a setting — a provider to connect, a spend limit, a disabled Agent's *Enable* — each on its own section.
Every way into the Agent's settings from its chat — the agent menu's *Agent settings* and *Add editors*, a reply's agent name, the empty chat's avatar, the assistant greeting's link, and the model pickers' *Manage providers* and *Configure defaults*, at the Providers section — opens the same modal over the chat: all of the Agent's sections and its restart bar, with the open section kept in the modal rather than in the address, so the conversation stays where it was.
Every way into the Agent's settings from its chat — the agent menu's *Agent settings* and *Add editors*, a reply's agent name, the empty chat's avatar, and the model pickers' *Manage providers* and *Configure defaults*, at the Providers section — opens the same modal over the chat: all of the Agent's sections and its restart bar, with the open section kept in the modal rather than in the address, so the conversation stays where it was.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Suggestion: AssistantGreeting still wires onConfigure to its SpeakerRow (packages/ui/src/modules/assistants/components/assistant-greeting.tsx:175). Name the assistant greeting's name here too, as .quality-inspector/qi-profile-dam/SKILL.md:39 does (docs/architecture/chat-view.md:29, packages/ui/src/modules/sessions/views/chat-view.tsx:834).

Suggested change
Every way into the Agent's settings from its chat — the agent menu's *Agent settings* and *Add editors*, a reply's agent name, the empty chat's avatar, and the model pickers' *Manage providers* and *Configure defaults*, at the Providers section — opens the same modal over the chat: all of the Agent's sections and its restart bar, with the open section kept in the modal rather than in the address, so the conversation stays where it was.
Every way into the Agent's settings from its chat — the agent menu's *Agent settings* and *Add editors*, a reply's agent name, the empty chat's avatar, the assistant greeting's name, and the model pickers' *Manage providers* and *Configure defaults*, at the Providers section — opens the same modal over the chat: all of the Agent's sections and its restart bar, with the open section kept in the modal rather than in the address, so the conversation stays where it was.

void toggleProcesses(selectedAgent);
};
/* UNIT_BOUNDARY_DESCRIPTION: every way into the Agent's settings from its chat — the top bar's name and wrench, a reply's agent name, the empty chat's avatar, the greeting's link, and the model pickers' provider links at the Providers section — opens the same modal over the chat; the modal links to the full page. */
/* UNIT_BOUNDARY_DESCRIPTION: every way into the Agent's settings from its chat — the top bar's name and wrench, a reply's agent name, the empty chat's avatar, and the model pickers' provider links at the Providers section — opens the same modal over the chat; the modal links to the full page. */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Suggestion: handleConfigureSandbox still feeds AssistantGreeting's onConfigure (packages/ui/src/modules/sessions/views/chat-view.tsx:983). Name the assistant greeting's name in this list too (packages/ui/src/modules/sessions/views/chat-view.tsx:834, docs/architecture/chat-view.md:29).

Suggested change
/* UNIT_BOUNDARY_DESCRIPTION: every way into the Agent's settings from its chat — the top bar's name and wrench, a reply's agent name, the empty chat's avatar, and the model pickers' provider links at the Providers section — opens the same modal over the chat; the modal links to the full page. */
/* UNIT_BOUNDARY_DESCRIPTION: every way into the Agent's settings from its chat — the top bar's name and wrench, a reply's agent name, the empty chat's avatar, the assistant greeting's name, and the model pickers' provider links at the Providers section — opens the same modal over the chat; the modal links to the full page. */

@dam-code-protector dam-code-protector Bot removed the code-guardian:review Add this label to trigger an automatic review by code-guardian. label Nov 18, 2026
@JanPokorny
JanPokorny merged commit c7002eb into main Nov 18, 2026
22 checks passed
@JanPokorny
JanPokorny deleted the fix/dammy-greeting-no-provider-line branch November 18, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant