Skip to content

Github Action for CI - #83

Merged
luciankt merged 5 commits into
csvistool:masterfrom
karkir0003:auto-linter-github-action
Sep 27, 2026
Merged

luciankt merged 5 commits into
csvistool:masterfrom
karkir0003:auto-linter-github-action

Conversation

@karkir0003

Copy link
Copy Markdown
Contributor

Context

I noticed in the contributing guidelines, developers are expected to run npm run prettier and npm run lint to make sure the formatting standards are complied with.

However, this seems to be a manual process and in order to codify the standards, I created a GitHub action that runs these two commands on PR creation to make life easier.

Changes Made

  • Introduced .github/workflows/ci.yaml to automatically run lint and prettier on PR creation to streamline process

@luciankt

Copy link
Copy Markdown
Collaborator

Appreciate this!

@karkir0003

Copy link
Copy Markdown
Contributor Author

Appreciate this!

Thanks! Can you also take a look at my other PR too. I think it'll be a valuable add to the tool

@luciankt

Copy link
Copy Markdown
Collaborator

I'm looking through your other PRs/Issues. In the meantime, could you check what might be the failure in this PR's CI run? Seems like the action failed before getting to the linting steps.
image

@karkir0003

karkir0003 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

I'm looking through your other PRs/Issues. In the meantime, could you check what might be the failure in this PR's CI run? Seems like the action failed before getting to the linting steps. image

The issue seems to be due to the fact that the branch that we are checking out doesn't exist in the context of this base repository. It shouldn't be a problem b/c in the followup, I'll run this script across the repo as a first pass to overcome the cold start

@luciankt

Copy link
Copy Markdown
Collaborator

Makes sense. Let me know if/when you are ready for this to be merged in then.

@karkir0003

Copy link
Copy Markdown
Contributor Author

im ready

@karkir0003

karkir0003 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

need to find a way to silence that failure haha or can you do an override to merge this in (like force merge)

@karkir0003

karkir0003 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

No conflicts with base branch

@luciankt this should be ready to get merged. Made some updates. Can you kick off the workflow and see if it works

@luciankt

Copy link
Copy Markdown
Collaborator

Perfect thanks!

@luciankt
luciankt merged commit 9e48a4f into csvistool:master Sep 27, 2026
@karkir0003

karkir0003 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

thanks @luciankt . can you also review #82 too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants