Github Action for CI - #83
Merged
Merged
Conversation
Collaborator
|
Appreciate this! |
Contributor
Author
Thanks! Can you also take a look at my other PR too. I think it'll be a valuable add to the tool |
Collaborator
Contributor
Author
Collaborator
|
Makes sense. Let me know if/when you are ready for this to be merged in then. |
Contributor
Author
|
im ready |
Contributor
Author
|
need to find a way to silence that failure haha or can you do an override to merge this in (like force merge) |
Contributor
Author
@luciankt this should be ready to get merged. Made some updates. Can you kick off the workflow and see if it works |
Collaborator
|
Perfect thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context
I noticed in the contributing guidelines, developers are expected to run
npm run prettierandnpm run lintto make sure the formatting standards are complied with.However, this seems to be a manual process and in order to codify the standards, I created a GitHub action that runs these two commands on PR creation to make life easier.
Changes Made
.github/workflows/ci.yamlto automatically run lint and prettier on PR creation to streamline process