CI Github Action Improvement - #84
Merged
luciankt merged 5 commits intoOct 1, 2026
Merged
Conversation
…tion code changing
Contributor
Author
|
@luciankt , can you review this! I made an update to the CI improvement process to better streamline the process. Let me know your thoughts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In #83 , I attempted to create a GitHub action to automate the
npm run lintandnpm run prettierchecks. However, after #83 got merged, I realized that there is a better setup that can simplify the problem. This PR tries to make things rightChanges Made
ci.yamlto act as a validation layer for enforcing the formatting standards as outlined in the contribution guidelinesCONTRIBUTING.mdto bring awareness to the automated hook to auto apply prettier and linting formatting standards.huskypre-commit hook that on commit automatically lints the staged files! No need to remember to manually runnpm run lintandnpm run prettierTest Plan
npm run lint && npm run prettiergit push