Repository navigation
perf(nix): prepare dev dependencies in Crane test artifacts - #315
Merged
davidabram merged 1 commit intoOct 11, 2026
Conversation
This was referenced Oct 10, 2026
davidabram
added this pull request to stack #319
October 10, 2026 21:11
davidabram
removed this pull request from stack #319
October 10, 2026 22:48
davidabram
added this pull request to stack #320
October 10, 2026 22:50
davidabram
marked this pull request as ready for review
October 10, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Step 5 of 8, stacked directly above #311; next PR will optimize Turso test-only artifacts.
Change
Set
doCheck = trueforcargoArtifactsTestand run onlycargoWithProfile check --locked --all-targetsin its build phase. The pinned Crane's check phase then runscargo test --locked --no-runagainst dummy sources, preparing the test and dev-dependency artifacts thatcli-testspreviously recompiled (24 crates). Do not run the redundantcargo buildduring deps preparation.This affects only the test-profile Crane derivation, shared by
cli-tests,cli-clippyand the opt-in Quint MBT check. Release and native artifacts remain unchanged.Validation
nix build .#checks.x86_64-linux.cli-tests -Lnix build .#checks.x86_64-linux.cli-clippy -Lnix flake check -Lon Linux and macOSnix logfor unexpected dependency recompilation; preserve 1,753 tests and 4 ignored.Benchmark caveat: This PR alone can be slower because it increases the dependency archive. The following two PRs remove the Turso FFI artifacts and dependency debug info; validate the final combination against experimental variant J (source-change
cli-tests~75s versus ~139s baseline). The reported measurements are local Linux measurements, not yet independently reproduced by this PR's CI.No tests or release outputs are deliberately changed.