You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I regenerated blueprint-types.generated.ts with pnpm generate:types. The SQL side is in constructive-io/constructive-db, where GuardStepUp, is_valid_step_up and the generated require_step_up now reject password_or_mfa.
Layer
Layer: the published node-type-registry schema for GuardStepUp.
What is removed: the password_or_mfa enum value and the description calling it the "legacy spelling of fresh_auth".
Why it was compat-only: the value existed only so blueprints written before fresh_auth kept validating. The platform is pre-launch, so there are no such blueprints.
This small change trims the step_up_type guard enum in packages/node-type-registry/src/guard/step-up.ts from four values to three, dropping password_or_mfa — which the removed doc comment described as the legacy spelling of fresh_auth. No in-repo code references the removed value, and the sibling data-lock.ts enum never included it, so the change is self-consistent within this repository. One low-severity compatibility note: configs persisted elsewhere with the legacy spelling would fail validation after upgrade; consider a validation-time alias if such configs exist. Review coverage of this diff was complete except for that note, which fell just under the confidence threshold and is not emitted as a formal finding.
Files
Change
packages/node-type-registry/src/guard/step-up.ts
Removes the password_or_mfa enum value and its legacy-alias note from the step_up_type definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This carries out the
password_or_mfadecision on constructive-io/constructive-planning#2152 for the publishednode-type-registry.I regenerated
blueprint-types.generated.tswithpnpm generate:types. The SQL side is in constructive-io/constructive-db, whereGuardStepUp,is_valid_step_upand the generatedrequire_step_upnow rejectpassword_or_mfa.Layer
GuardStepUp.password_or_mfaenum value and the description calling it the "legacy spelling of fresh_auth".fresh_authkept validating. The platform is pre-launch, so there are no such blueprints.Link to Devin session: https://app.devin.ai/sessions/0f9216183d904190b25c5344962e2f12
Open in Devin Desktop: https://app.devin.ai/desktop/session/0f9216183d904190b25c5344962e2f12?variant=devin
Requested by: @pyramation