Skip to content

Revert "feat(node-type-registry): GuardStepUp accepts only fresh_auth, not password_or_mfa" - #1871

Merged
pyramation merged 1 commit into
mainfrom
revert-1870-feat/step-up-fresh-auth-only
Oct 1, 2026
Merged

pyramation merged 1 commit into
mainfrom
revert-1870-feat/step-up-fresh-auth-only

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Reverts #1870

@tenki-reviewer

tenki-reviewer Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review complete. No blocking issues — approved ✅; 1 nitpick below.

🧹 Nitpicks (1) — 🟢 1 low
  • 🟢 Add password_or_mfa alias to DataLock.step_up_type (data-lock.ts:46) — The PR re-accepts the legacy password_or_mfa spelling of fresh_auth on GuardStepUp (packages/node-type-registry/src/guard/step-up.ts:23), but the sibling DataLock definition's step_up_type enum (packages/node-type-registry/src/data/data-lock.ts:48) still allows only password, mfa, and fresh_auth.

This PR extends the step-up verification enum in packages/node-type-registry/src/guard/step-up.ts with a password_or_mfa value as an alias for the existing fresh_auth option.

Files Change
packages/node-type-registry/src/guard/step-up.ts Adds password_or_mfa to the step_up_type enum alongside fresh_auth.

Reviewed commit: 83a996c

@pyramation
pyramation merged commit f045f15 into main Oct 1, 2026
4 checks passed
@pyramation
pyramation deleted the revert-1870-feat/step-up-fresh-auth-only branch October 1, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant