Skip to content

fix: a parser reading the CV in order finds each bullet under its role #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderback merged 1 commit into from
Oct 20, 2026
Merged

fix: a parser reading the CV in order finds each bullet under its role #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions api/app/templates/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ body.cv {
.cv-entry-title { font-weight: 700; }
.cv-dates { flex-shrink: 0; margin-right: 44pt; font-size: 9pt; color: #595959; white-space: nowrap; }
.cv-bullets { margin: 0; padding: 0 0 0 36pt; list-style: none; }
.cv-bullets li { position: relative; margin: 0; }
.cv-bullets li::before { content: "•"; position: absolute; left: -18pt; font-family: Arial, "Liberation Sans", sans-serif; }
.cv-bullets li { margin: 0; }
/* The bullet sits in the line, hung into the list's indent, rather than positioned: WeasyPrint draws positioned
boxes after the page's other text, so a parser reading the PDF in order found every bullet after Skills. */
.cv-bullets li::before { content: "•"; display: inline-block; width: 18pt; margin-left: -18pt; line-height: 1;
font-family: Arial, "Liberation Sans", sans-serif; }
.cv-muted { font-size: 9pt; color: #595959; }

/* ── Fit to page ────────────────────────────────────────────────────── */
Expand Down
11 changes: 11 additions & 0 deletions api/tests/test_documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,17 @@ def test_the_graduate_cv_is_one_page_in_the_designs_type_with_live_links(pdf_dir
assert {"mailto:sam@example.com", "https://github.com/samokafor"} <= uris


@needs_weasyprint
def test_a_parser_reading_the_cv_in_order_finds_each_bullet_under_its_role(pdf_dir):
# A parser reads the PDF in the order it was drawn. A positioned bullet marker was drawn after the page's other
# text, so every experience bullet came after the Skills section, cut off from its role.
cv = agent._persona_to_cvdoc(GRADUATE) | {"seniority": "junior"}
text = " ".join(_weasy("cv", cv)[0].get_text().split())
order = ["Software Engineering Intern", "Built a FastAPI service that ingests 40k", "Pantry Planner",
"Skills & Technical Proficiency"]
assert [text.index(s) for s in order] == sorted(text.index(s) for s in order)


@needs_weasyprint
def test_a_full_graduate_cv_fits_one_page(pdf_dir):
# Everything the tailoring prompt allows a junior: a 3-sentence summary, three roles with 2 bullets of
Expand Down
Loading