Repository navigation
fix: a parser reading the CV in order finds each bullet under its role - #65
Merged
Merged
Conversation
The CV's bullet marker was absolutely positioned, and WeasyPrint draws positioned boxes after the page's other text. A parser reading the PDF in order (pypdf, PyMuPDF, an ATS that indexes the file) found every experience bullet after the Skills section, cut off from its role. The marker is now an inline-block hung into the list's indent, so it is drawn in line with its text. On the candidate's CV every one of 673 words lands within 0.2pt of where it did, with the markers in the same column; the reading order is role, its bullets, Projects, Skills. A new WeasyPrint test checks that order and fails on the old styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A program reading the CV PDF in order (pypdf, PyMuPDF, or an ATS that indexes the file) found every experience bullet after the Skills section, cut off from its role. On the Catapult CV, the Rootlayer heading came at line 9 of 65, Skills at 37 and its first bullet at 45. A person sees the page normally, so it never showed in the preview.
The cause: the bullet marker (
.cv-bullets li::before) was absolutely positioned inside aposition: relativelist item. WeasyPrint draws positioned boxes after the page's other text.What changed
base.css: the marker is now an inline-block, 18pt wide with a -18pt margin, hung into the list's indent withline-height: 1, so it is drawn in line with its text. The list item is no longer positioned.Tests
test_a_parser_reading_the_cv_in_order_finds_each_bullet_under_its_role: the role title, its first bullet, the first project, then Skills, in that order. It fails on the old styling and passes on the new.After deploy
Rebuild the API with
docker compose up -d --build api. This is independent of #64; one rebuild after both picks up everything.