Skip to content

Start a held cron scheduler without repeating bootstrap writes - #272

Merged
shiny-code-app[bot] merged 2 commits into
mainfrom
work/lp3268-1025-scheduler
Oct 25, 2026
Merged

shiny-code-app[bot] merged 2 commits into
mainfrom
work/lp3268-1025-scheduler

Conversation

@shiny-code-app

Copy link
Copy Markdown
Contributor

A second Odoo startup process currently repeats bootstrap writes and serves HTTP. Add a scheduler-only launch behind the exact committed slot run marker, with HTTP disabled and cron enabled, that skips initialization, overrides and administrator changes. This supplies the prerequisite for Launchplane's writer-binding work.

Closes #271. Refs cbusillo/launchplane#3268.

Validation: all 40 startup, 87 data-workflow and 7 override-guard tests pass; Ruff lint and format pass. Native PyCharm inspection is UNKNOWN (native_interrupted_run_unresolved); cleanup closed, no engine was launched, and its existing journal is preserved. Consumer builds are being collected before Ready.

Anthropic claude-opus-5-5[1m] reviewed 78c5f1a with no blocking defects. Strengthened the existing test for preflight/first-marker ordering and changed its cron assertion to positive capacity. Declined the doc nit: the token is the slot serialization SHA-256 supplied by the caller, and the consumer intentionally compares it without recomputing the plan. Removed the fixture-only getattr fallback. No unresolved finding.

Removed: repeated scheduler bootstrap phases and HTTP serving from its startup path. Net lines: +90 (startup mode, behavioral coverage and its caller contract).

Client test notes

Nothing for the Client to test: this is an internal runtime startup capability; Launchplane lane activation and release qualification remain separately tracked.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Review result: weighed
Head: 07cd0f2

Anthropic claude-opus-5-5[1m] reviewed 78c5f1a; no blocking defect. Weighed all findings against current head 07cd0f2:

  1. Reproduced the test coverage gap by inspection of the existing test. Strengthened it to require credential preflight first, no config/database wait without the first committed marker, and config/database/lock order. Missing/wrong/withdrawn marker cases still refuse execution. All 40 startup tests pass.
  2. Removed the exact thread/worker count assertions and check positive cron capacity; HTTP-off remains asserted as the required behavior.
  3. Removed fixture-only getattr and supplied scheduler=False in the fixture.
  4. Declined the wording nit: the caller's slot serialization digest is SHA-256. This consumer compares the supplied digest and does not recompute the caller's plan.

No unresolved finding. Safety modules: startup (40), data workflows (87), override guards (7) passed. Ruff lint/format passed. Native inspection UNKNOWN/native_interrupted_run_unresolved, no retry; pre-existing journal preserved.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Both required tenant production artifact build-only checks passed for devkit/runtime 07cd0f2be22ecbf3b30a111608cbe0bdd2bcf538 on linux/amd64:

Downloaded and checked both consumer-build-check-1 artifacts: kind=artifact_build_check, exact runtime/source commits and production platform agree; image/dependency evidence is retained in each artifact. These checks publish no image or deployment. Ordinary devkit live Odoo CI remains pending.

Removed: repeated scheduler bootstrap phases and HTTP serving from its startup path. Net lines: +90 (92 additions, 2 removals).

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Ready for the merge train

Head: 07cd0f2

@shiny-code-app shiny-code-app Bot added the ready-to-merge Every Code PR is ready for repository owner merge review label Oct 25, 2026
shiny-code-app Bot added a commit that referenced this pull request Oct 25, 2026
@shiny-code-app

shiny-code-app Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Launchplane completed the merge-train step for this pull request.

Launchplane finished the merge-train step for this pull request.

Launchplane manages this comment and will update it as the train moves.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Post-merge verification is complete at landing 746015e: CI, main static/CodeQL and live Odoo checks all passed. #271's exact claim release is read back, its task worktree is retired, and primary main is clean/current at the landing. The Launchplane source delivery continues in #4846; no product release started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Every Code PR is ready for repository owner merge review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launch a held cron scheduler without repeating startup writes

0 participants