Repository navigation
Start a held cron scheduler without repeating bootstrap writes - #272
Conversation
|
Review result: weighed Anthropic claude-opus-5-5[1m] reviewed 78c5f1a; no blocking defect. Weighed all findings against current head 07cd0f2:
No unresolved finding. Safety modules: startup (40), data workflows (87), override guards (7) passed. Ruff lint/format passed. Native inspection UNKNOWN/native_interrupted_run_unresolved, no retry; pre-existing journal preserved. |
|
Both required tenant production artifact build-only checks passed for devkit/runtime
Downloaded and checked both Removed: repeated scheduler bootstrap phases and HTTP serving from its startup path. Net lines: +90 (92 additions, 2 removals). |
|
Ready for the merge train Head: 07cd0f2 |
…b1c79331429b86e: merge PR #272
|
Launchplane completed the merge-train step for this pull request.
Launchplane finished the merge-train step for this pull request. Launchplane manages this comment and will update it as the train moves. |
|
Post-merge verification is complete at landing 746015e: CI, main static/CodeQL and live Odoo checks all passed. #271's exact claim release is read back, its task worktree is retired, and primary main is clean/current at the landing. The Launchplane source delivery continues in #4846; no product release started. |
A second Odoo startup process currently repeats bootstrap writes and serves HTTP. Add a scheduler-only launch behind the exact committed slot run marker, with HTTP disabled and cron enabled, that skips initialization, overrides and administrator changes. This supplies the prerequisite for Launchplane's writer-binding work.
Closes #271. Refs cbusillo/launchplane#3268.
Validation: all 40 startup, 87 data-workflow and 7 override-guard tests pass; Ruff lint and format pass. Native PyCharm inspection is UNKNOWN (
native_interrupted_run_unresolved); cleanup closed, no engine was launched, and its existing journal is preserved. Consumer builds are being collected before Ready.Anthropic claude-opus-5-5[1m] reviewed 78c5f1a with no blocking defects. Strengthened the existing test for preflight/first-marker ordering and changed its cron assertion to positive capacity. Declined the doc nit: the token is the slot serialization SHA-256 supplied by the caller, and the consumer intentionally compares it without recomputing the plan. Removed the fixture-only
getattrfallback. No unresolved finding.Removed: repeated scheduler bootstrap phases and HTTP serving from its startup path. Net lines: +90 (startup mode, behavioral coverage and its caller contract).
Client test notes
Nothing for the Client to test: this is an internal runtime startup capability; Launchplane lane activation and release qualification remain separately tracked.