Repository navigation
feat(pip): report PiP state changes the host didn't request - #44
Merged
Merged
Conversation
PictureInPictureBridge.isActive moved only through its delegate and nothing could observe it, so the host never learned that the system had started PiP by itself or that the user had closed the window with its ✕. Lume showed the wrong PiP button state, paused the stream when the app went to the background during PiP, and kept the session alive after a dismissal. onActiveChange fires on the main actor once per actual change; a stop after a failed start doesn't repeat the false.
Merged
9 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PictureInPictureBridge.isActive moved only through its delegate and nothing
could observe it, so the host never learned that the system had started PiP
by itself or that the user had closed the window with its ✕. Lume showed the
wrong PiP button state, paused the stream when the app went to the background
during PiP, and kept the session alive after a dismissal.
onActiveChange fires on the main actor once per actual change; a stop after a
failed start doesn't repeat the false.