Repository navigation
Conversation
`shutdown()` cancels the pump tasks, so the `.openFailed` event that would resume `openContinuation` is never delivered. A `load` still waiting on the demuxer when its session is replaced (for example a quick channel change while the previous stream is opening) then never returns, and the caller keeps the whole session alive for good. Resume the pending open with `EngineError(code: .cancelled)` at the start of `shutdown()`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PlayerSession.shutdown()now resumes a pendingopenContinuationwithEngineError(code: .cancelled)before tearing down.Why
shutdown()cancels the pump tasks, so the.openFailedevent that would resumeopenContinuationis never delivered. If a session is replaced while itsloadis still waiting on the demuxer, thatloadnever returns, and the caller keeps the whole session (demuxer, decoders, renderers) alive for good.We hit this in a live-TV app: changing channel quickly, while the previous stream was still opening, leaked one suspended session per quick change.
Notes
🤖 Generated with Claude Code