Repository navigation
Expose output volume on LumePlayer - #37
Merged
Merged
Conversation
`SystemRenderer` already has a `volume`, but a host can't reach it through `LumePlayer`, so it can't fade audio in or out. Audio that starts or stops mid-waveform at full level is heard as a click, which is most noticeable when a live-TV host changes channel quickly. `volume` (0...1) is applied to the current session and carried across `load`, so a host can open a stream silent and ramp it up once playback starts, and ramp it down before replacing or stopping a session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bilipp
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
volumeproperty (0...1) onLumePlayer, forwarded to the session'sSystemRenderer.volumeand carried acrossload.Why
SystemRendereralready hasvolume, but a host can't reach it throughLumePlayer, so it can't fade audio. Audio that starts or stops mid-waveform at full level is heard as a click. It's most noticeable in a live-TV app that changes channel quickly: the old session is torn down while it's playing, and the new one starts mid-programme at full level.With this, a host can open a stream silent, ramp it up once the state reaches
.playing, and ramp it down before replacing or stopping a session. We use a 40 ms fade out and a 150 ms fade in, and the clicks on channel changes got noticeably better.Notes
🤖 Generated with Claude Code