Skip to content

fix(data_classes): return None from TransferFamilyAuthorizer.password when the event has none #8715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandrodamascena merged 2 commits into from
Nov 4, 2026
Merged

fix(data_classes): return None from TransferFamilyAuthorizer.password when the event has none #8715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f609fe3
fix(data_classes): return None from TransferFamilyAuthorizer.password…
anishmehta24 Oct 30, 2026
30832a9
Merge branch 'develop' into fix/transfer-family-password-optional
leandrodamascena Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws_lambda_powertools/utilities/data_classes/transfer_family_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def username(self) -> str:
def password(self) -> str | None:
"""
The password used for authentication.
None in case customer authenticating with certificates
None when the event has no password, e.g. when the user authenticates with an SSH key
"""
return self["password"]
return self.get("password")

@property
def protocol(self) -> str:
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/data_classes/required_dependencies/test_transfer_family_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,16 @@ def test_transfer_family_authorizer_event():
assert parsed_event.source_ip == raw_event["sourceIp"]


def test_transfer_family_authorizer_event_without_password():
# GIVEN an authorizer event with no password, as for a user authenticating with an SSH key
raw_event = load_event("transferFamilyAuthorizer.json")
del raw_event["password"]

# WHEN reading the password
# THEN it is None, matching the property's type and the Pydantic model's default
assert TransferFamilyAuthorizer(raw_event).password is None


@pytest.mark.parametrize("home_directory_type", ["LOGICAL", "PATH"])
def test_build_authentication_response_s3(home_directory_type):
# GIVEN a Authorizer response
Expand Down
Loading