Skip to content

fix(data_classes): return None from TransferFamilyAuthorizer.password when the event has none - #8715

Merged
leandrodamascena merged 2 commits into
aws-powertools:developfrom
anishmehta24:fix/transfer-family-password-optional
Nov 4, 2026
Merged

leandrodamascena merged 2 commits into
aws-powertools:developfrom
anishmehta24:fix/transfer-family-password-optional

Conversation

@anishmehta24

Copy link
Copy Markdown
Contributor

Issue number: closes #8714

Summary

Changes

TransferFamilyAuthorizer.password is typed str | None and documented as None for non-password logins, but indexed the event directly, so an event without password raised KeyError. It now returns self.get("password"), matching the Pydantic model, which already defaults password to None. The docstring now says it's None when the event has no password (e.g. SSH key login) rather than mentioning certificates.

Added test_transfer_family_authorizer_event_without_password in tests/unit/data_classes/required_dependencies/test_transfer_family_event.py; it fails on develop with KeyError: 'password'.

User experience

Before: TransferFamilyAuthorizer(event).password raises KeyError when the event has no password. After: it returns None.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anishmehta24, confirmed. Transfer Family only sends password for password logins, the AWS sample identity provider itself checks for the missing key, and our Pydantic model already defaults it to None, so the data class was the odd one out.

I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (8074a54) to head (30832a9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8715   +/-   ##
========================================
  Coverage    97.02%   97.02%           
========================================
  Files          321      321           
  Lines        16443    16443           
  Branches      1487     1487           
========================================
  Hits         15954    15954           
  Misses         349      349           
  Partials       140      140           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena
leandrodamascena merged commit c8da226 into aws-powertools:develop Nov 4, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: TransferFamilyAuthorizer.password raises KeyError when the event has no password

2 participants