Repository navigation
ADFA-6864 | Drop the unused jitpack.io repository from AI-Core - #158
Open
davidschachterADFA wants to merge 1 commit into
Open
davidschachterADFA wants to merge 1 commit into
davidschachterADFA wants to merge 1 commit into
Conversation
No AI-Core dependency comes from it: all eight are on Google or Maven Central. With FAIL_ON_PROJECT_REPOS, a third-party host would otherwise be asked to serve any coordinate those two lack. assemblePlugin still passes without it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vh2DAaJxvRXKRYkgiDqwGQ
5 tasks done
Contributor
Author
|
@Daniel-ADFA @hal-eisen-adfa, could one of you review this? It's a one-line deletion that removes the unused jitpack.io repository from AI-Core's It's been checked more thoroughly than the diff suggests. An independent review built AI-Core from an empty Gradle cache. All 287 libraries came from Google and Maven Central, with no request to jitpack.io. With the line put back, the downloaded libraries were identical. Posted by Claude Code for David Schachter. |
hal-eisen-adfa
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADFA-6864. Removes
maven { url = uri("https://jitpack.io") }fromplugins/AI-Core/settings.gradle.kts. No AI-Core dependency comes from it. Built from an empty Gradle cache, AI-Core resolved all 287 libraries from Google and Maven Central and sent no request to jitpack.io. The 287 are its eight implementation dependencies (androidx, Material, Kotlin stdlib, coroutines, Markwon, Gson), its seven test dependencies, and everything they pull in.Gradle asks every repository listed in
settings.gradle.kts, so JitPack remains a possible source until the line goes.FAIL_ON_PROJECT_REPOSonly stops build files from adding repositories of their own. For a fixed version, Gradle asks JitPack only when Google and Maven Central lack the library. For a dynamic version such as1.+, it asks every repository and takes the newest, so JitPack could supply a newer copy even of a library the other two have. Nothing in AI-Core triggers either case today: every version is fixed, and every library is on Google or Maven Central. This is a supply-chain tidy-up, found by the/plugin-reviewsecurity audit (finding F17).The line came in with the move under
plugins/(ADFA-6167). Seven other plugins and the Demo (jME) template still have it, and this PR leaves them alone. ADFA-6865 covers the five AI-Agent plugins and the template. Layout-Editor and Icons-Repository usecom.github.*libraries, but that name does not mean the library comes from JitPack: all four (glide,colorpickerview,svg-generator,svg-support) are on Maven Central. Whether anything those four pull in needs JitPack was not checked.Verification
An independent review on 2026-10-30 started from an empty Gradle cache (Gradle 9.6.1):
assemblePluginand checked the build record withscripts/verify-provenance.sh(revisione7b64d1c, from git, not dirty).The only automatic check on pull requests here, "Toolchain versions", reads files and never runs Gradle, so it does not test this change. The workflows that build plugins run only by hand.
Not verified
Test plan
assemblePluginfor AI-Core passes without the line, from an empty Gradle cacheaddons checkexits 0🤖 Generated with Claude Code
https://claude.ai/code/session_01Vh2DAaJxvRXKRYkgiDqwGQ