Repository navigation
ADFA-6865 | Drop the unused jitpack.io repository from the AI-Agent plugins and the Demo (jME) template - #159
Open
davidschachterADFA wants to merge 3 commits into
Open
davidschachterADFA wants to merge 3 commits into
davidschachterADFA wants to merge 3 commits into
Conversation
…lugins None of AI-Agent-Claude, -Gemini, -Local, -MCP or -OpenAI declares a com.github.* dependency. With FAIL_ON_PROJECT_REPOS, Gradle still asks JitPack when resolving, so a third-party host could serve an artifact for any coordinate that Google and Maven Central lack. Same change as ADFA-6864 made for AI-Core. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
… template The Demo's only dependencies are four jME jars that the bundle build downloads from Maven Central into app/libs. Block Game and Bubble Wand, in the same bundle, already build without JitPack. Every project generated from the Demo carried the line. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
The bundle README said the only change from upstream FunandGames-jme is the app/libs jars. Demo's settings.gradle.peb now differs too, and upstream still lists jitpack.io, so a sync that trusted the old note would bring the line back. The Demo project README now says libraries resolve from Google and Maven Central only, and how to add JitPack back for a library hosted there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
Contributor
Author
|
@Daniel-ADFA @hal-eisen-adfa, could one of you review this too? It removes the unused jitpack.io repository from the five AI-Agent plugins and the Demo (jME) template: six one-line deletions, plus a README note. From an empty Gradle cache, all five plugins resolve only from Google and Maven Central, and the resolved libraries are identical with and without the line. Unit tests (1,032) pass, and it was checked on a Pixel 6 Pro: plugins load, settings open, and a Demo project builds and runs. An independent review found no bugs; its doc findings are fixed and the regression guard is ADFA-6873. Posted by Claude Code for David Schachter. |
hal-eisen-adfa
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-6865
Summary
Removes
maven { url = uri("https://jitpack.io") }fromsettings.gradle.ktsin AI-Agent-Claude, -Gemini, -Local, -MCP and -OpenAI, and fromtemplates/Fun-and-Games-JME/demo/settings.gradle.peb. Six one-line deletions in two commits, plugins then template. A third commit updates the template's READMEs.None of the five plugins declares a
com.github.*dependency. The Demo's only dependencies are four jME jars that the bundle build downloads from Maven Central intoapp/libs. PR #158 (ADFA-6864) makes the same change for AI-Core. It is still open, so AI-Core onmainstill lists the line.For a fixed version, Gradle stops at the first listed repository that has the module. So today Gradle asks JitPack only for a library that Google and Maven Central lack, and JitPack could then supply that library. For a dynamic version such as
1.+, Gradle asks every repository and takes the newest. In the template, the line also lands in users' own projects. This is a supply-chain tidy-up, not a defect.The bundle README now names Demo's
settings.gradle.pebas a second difference from upstreamFunandGames-jme, which still lists jitpack.io, so a sync from upstream keeps the change. The Demo project's own README says libraries resolve from Google and Maven Central only, and how to add JitPack back for a library hosted there.Verified
llama-apiandllama-impl), run with--refresh-dependencies. NoFAILEDlines.assemblePluginandtestDebugUnitTestsucceed for all five. The--infologs contain no "jitpack". Downloads came only fromdl.google.comandrepo.maven.apache.org, plus the Gradle distribution.addons checkexits 0. The template bundle builds at the head commit, and the jME jar checksums match.scripts/check-toolchain.shreports 10 problems, all inside the vendoredplugins/AI-Agent-Local/subprojects/llama.cppsubmodule, which CI does not check out.C-d-1030-1721), with the bundle built ata57a8624(the README commit after it changes only text):jitpack.ioanywhere, and it builds, installs and runs (3D Earth with an orbiting rocket). Dragging rotates the Earth, confirmed by hand.Review
An independent
/code-reviewfound no correctness bugs. Its findings are handled as follows:template.versionstays 1.0.0, as in ADFA-6568 | Rename the Tetris template to Block Game #140.Not verified
Not in scope: Layout-Editor and Icons-Repository, and AI-Core (#158).
Test plan
addons check🤖 Generated with Claude Code
https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP