Skip to content

ADFA-6865 | Drop the unused jitpack.io repository from the AI-Agent plugins and the Demo (jME) template - #159

Open
davidschachterADFA wants to merge 3 commits into
mainfrom
ADFA-6865
Open

davidschachterADFA wants to merge 3 commits into
mainfrom
ADFA-6865

Conversation

@davidschachterADFA

@davidschachterADFA davidschachterADFA commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

ADFA-6865

Summary

Removes maven { url = uri("https://jitpack.io") } from settings.gradle.kts in AI-Agent-Claude, -Gemini, -Local, -MCP and -OpenAI, and from templates/Fun-and-Games-JME/demo/settings.gradle.peb. Six one-line deletions in two commits, plugins then template. A third commit updates the template's READMEs.

None of the five plugins declares a com.github.* dependency. The Demo's only dependencies are four jME jars that the bundle build downloads from Maven Central into app/libs. PR #158 (ADFA-6864) makes the same change for AI-Core. It is still open, so AI-Core on main still lists the line.

For a fixed version, Gradle stops at the first listed repository that has the module. So today Gradle asks JitPack only for a library that Google and Maven Central lack, and JitPack could then supply that library. For a dynamic version such as 1.+, Gradle asks every repository and takes the newest. In the template, the line also lands in users' own projects. This is a supply-chain tidy-up, not a defect.

The bundle README now names Demo's settings.gradle.peb as a second difference from upstream FunandGames-jme, which still lists jitpack.io, so a sync from upstream keeps the change. The Demo project's own README says libraries resolve from Google and Maven Central only, and how to add JitPack back for a library hosted there.

Verified

  • Resolved dependencies are identical before and after the change for all five plugins (AI-Agent-Local includes llama-api and llama-impl), run with --refresh-dependencies. No FAILED lines.
  • With an empty Gradle home, assemblePlugin and testDebugUnitTest succeed for all five. The --info logs contain no "jitpack". Downloads came only from dl.google.com and repo.maven.apache.org, plus the Gradle distribution.
  • Unit tests pass: Claude 210, Gemini 128, Local 257, MCP 147, OpenAI 290.
  • addons check exits 0. The template bundle builds at the head commit, and the jME jar checksums match.
  • "Toolchain versions" passes in CI. Locally, scripts/check-toolchain.sh reports 10 problems, all inside the vendored plugins/AI-Agent-Local/subprojects/llama.cpp submodule, which CI does not check out.
  • Device (Pixel 6 Pro, arm64, debug Code on the Go C-d-1030-1721), with the bundle built at a57a8624 (the README commit after it changes only text):
    • All five plugins install and log "Successfully loaded and activated" after a restart.
    • The settings pane renders for Claude, Gemini API, Local LLM and OpenAI, and the MCP servers screen opens.
    • A project generated from Demo (jME) has no jitpack.io anywhere, and it builds, installs and runs (3D Earth with an orbiting rocket). Dragging rotates the Earth, confirmed by hand.

Review

An independent /code-review found no correctness bugs. Its findings are handled as follows:

Not verified

  • Nothing beyond the settings panes of the four backends: no API keys were used, and the Local model was not loaded (the saved model file is unreachable on the test phone).
  • Block Game and Bubble Wand were not run. Their files are unchanged.

Not in scope: Layout-Editor and Icons-Repository, and AI-Core (#158).

Test plan

  • Dependency sets identical before and after
  • Empty-cache build and unit tests, five plugins
  • addons check
  • Device: plugins load, settings panes open, Demo (jME) project builds and runs
  • CI ("Toolchain versions"), all three commits

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP

davidschachterADFA and others added 3 commits October 30, 2026 14:41
…lugins

None of AI-Agent-Claude, -Gemini, -Local, -MCP or -OpenAI declares a
com.github.* dependency. With FAIL_ON_PROJECT_REPOS, Gradle still asks
JitPack when resolving, so a third-party host could serve an artifact for
any coordinate that Google and Maven Central lack.

Same change as ADFA-6864 made for AI-Core.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
… template

The Demo's only dependencies are four jME jars that the bundle build
downloads from Maven Central into app/libs. Block Game and Bubble Wand, in
the same bundle, already build without JitPack. Every project generated
from the Demo carried the line.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
The bundle README said the only change from upstream FunandGames-jme is
the app/libs jars. Demo's settings.gradle.peb now differs too, and
upstream still lists jitpack.io, so a sync that trusted the old note would
bring the line back.

The Demo project README now says libraries resolve from Google and Maven
Central only, and how to add JitPack back for a library hosted there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vh2DAZr1SdakZ8MdHYBUyP
@davidschachterADFA

Copy link
Copy Markdown
Contributor Author

@Daniel-ADFA @hal-eisen-adfa, could one of you review this too? It removes the unused jitpack.io repository from the five AI-Agent plugins and the Demo (jME) template: six one-line deletions, plus a README note. From an empty Gradle cache, all five plugins resolve only from Google and Maven Central, and the resolved libraries are identical with and without the line. Unit tests (1,032) pass, and it was checked on a Pixel 6 Pro: plugins load, settings open, and a Demo project builds and runs. An independent review found no bugs; its doc findings are fixed and the regression guard is ADFA-6873.

Posted by Claude Code for David Schachter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants