Repository navigation
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28dcd15a8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| require(claimSets == null) { | ||
| "An ISO DeviceRequest can not express the claim combinations of $id" | ||
| } |
There was a problem hiding this comment.
Preserve single-option claim sets
When a legal DCQL query has exactly one claim_sets option containing every listed claim, there is no alternative selection: the resulting DeviceRequest can request those same data elements exactly, as the previous implementation did. This blanket rejection therefore breaks an expressible request, despite the converter's contract only rejecting constructs an ISO request cannot represent; accept or normalize this degenerate form while continuing to reject genuine alternatives.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
normalisation is the way to go (assuming the comment makes sense)
28dcd15 to
6b36ae1
Compare
|
@codex review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b36ae1ea2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6b36ae1 to
73ab458
Compare
38222d1 to
5f9c5e0
Compare
The holder presents the first claim combination its credential satisfies, omits all claims requested if available when one is missing, and presents an SD-JWT without disclosures if only missing claims are requested if available. The default submission presents the first satisfiable option of each required credential set and no optional set; a submission built by the wallet may add optional sets. The verifier accepts each of these presentations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DCQLQuery.toIso180137AnnexCDeviceRequest fails for claim_sets with several options, credential_sets other than required sets with a single option that together request every credential query, expected claim values, multiple, and trusted_authorities, instead of requesting more or other than the query does. A single option of claim_sets requests its claims, and a data element queried twice is requested once. DcApiVerifier.createAuthnRequest converts the request for ISO/IEC 18013-7 Annex C before creating any request, so a query that can not be converted creates no nonce, ephemeral key, or stored request for any exchange protocol. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5f9c5e0 to
8db0e5b
Compare
Uses data types introduced in #802 to correctly build queries for credentials, both in OpenID4VP and ISO Device Retrieval.