Skip to content

Request Credential Sets: Usage - #803

Open
nodh wants to merge 3 commits into
feature/request-credential-sets-data-typesfrom
feature/request-credential-sets-usage
Open

nodh wants to merge 3 commits into
feature/request-credential-sets-data-typesfrom
feature/request-credential-sets-usage

Conversation

@nodh

@nodh nodh commented Nov 16, 2026

Copy link
Copy Markdown
Member

Uses data types introduced in #802 to correctly build queries for credentials, both in OpenID4VP and ISO Device Retrieval.

@nodh nodh added this to the 10.0 milestone Nov 16, 2026
@nodh
nodh requested review from JesusMcCloud and tlenz November 16, 2026 13:23
@nodh nodh self-assigned this Nov 16, 2026
@nodh
nodh added this pull request to stack #797 November 16, 2026 13:23

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T09:01:40.542573Z 6b36ae1 Manual request
🔒 Security Review ✅ Completed 2026-11-16T13:27:26.540733Z 28dcd15 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nodh

nodh commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28dcd15a8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +54 to +56
require(claimSets == null) {
"An ISO DeviceRequest can not express the claim combinations of $id"
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve single-option claim sets

When a legal DCQL query has exactly one claim_sets option containing every listed claim, there is no alternative selection: the resulting DeviceRequest can request those same data elements exactly, as the previous implementation did. This blanket rejection therefore breaks an expressible request, despite the converter's contract only rejecting constructs an ISO request cannot represent; accept or normalize this degenerate form while continuing to reject genuine alternatives.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalisation is the way to go (assuming the comment makes sense)

@nodh
nodh force-pushed the feature/request-credential-sets-usage branch from 28dcd15 to 6b36ae1 Compare November 18, 2026 08:56
@nodh

nodh commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

@codex review again

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b36ae1ea2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nodh
nodh force-pushed the feature/request-credential-sets-usage branch from 6b36ae1 to 73ab458 Compare November 18, 2026 09:08
@nodh
nodh force-pushed the feature/request-credential-sets-usage branch 2 times, most recently from 38222d1 to 5f9c5e0 Compare November 18, 2026 10:10
nodh and others added 3 commits November 19, 2026 10:56
The holder presents the first claim combination its credential
satisfies, omits all claims requested if available when one is
missing, and presents an SD-JWT without disclosures if only missing
claims are requested if available. The default submission presents the
first satisfiable option of each required credential set and no
optional set; a submission built by the wallet may add optional sets.
The verifier accepts each of these presentations.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DCQLQuery.toIso180137AnnexCDeviceRequest fails for claim_sets with
several options, credential_sets other than required sets with a
single option that together request every credential query, expected
claim values, multiple, and trusted_authorities, instead of requesting
more or other than the query does. A single option of claim_sets
requests its claims, and a data element queried twice is requested
once.

DcApiVerifier.createAuthnRequest converts the request for ISO/IEC
18013-7 Annex C before creating any request, so a query that can not be
converted creates no nonce, ephemeral key, or stored request for any
exchange protocol.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nodh
nodh force-pushed the feature/request-credential-sets-usage branch from 5f9c5e0 to 8db0e5b Compare November 19, 2026 09:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants