Repository navigation
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
The new bridge suite repeatedly invokes the behavior under test directly inside matcher chains, so the Act phase is not separated from Assert; the first cases also exercise multiple behaviors in one action block. Store each single action's result, then assert on it in a final block, splitting multi-behavior cases where necessary, to follow the repository's required Arrange–Act–Assert structure.
AGENTS.md reference: AGENTS.md:L36-L39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9f9ef98 to
086b03a
Compare
|
@codex review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 086b03a210
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4965f63 to
ecf0530
Compare
4d99258 to
9886aba
Compare
Migrate the tests of vck-openid and the README example from RequestOptionsCredential to RequestedCredential, with VC-JWT claims paths from the root of the VC and mdoc data elements as MdocClaimReferences. Schemes resolved from AttributeIndex are checked to be of the typed scheme interface the format needs. RequestOptionsCredential stays in RequestOptionsCredentialBridgeTest (renamed from CredentialPresentationRequestBuilderTest), in the bridge section of RequestedPresentationQueryTest, and in the two end-to-end tests of its credentialSubject prefixing and mdoc path parsing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deprecate RequestOptionsCredential, RequestedAttributePaths, and the CredentialPresentationRequestBuilder entry points taking RequestOptionsCredentials, with ReplaceWith where the replacement is mechanical, and remove the unused RequestedAttributes alias. Tests of the deprecated conversion are gathered in RequestOptionsCredentialBridgeTest. Test the new request types from Java, and describe them in ARCHITECTURE.md and the CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uthorize it OpenId4VpRequestOptions required the credential_ids of all transaction data together to equal the IDs of all credential queries. OpenID4VP 1.0, 5.1 only requires each to reference "a Credential requested by the Verifier that can be used to authorize this transaction", so a request with an optional credential, or alternatives of which only some authorize the transaction, was rejected. Require only that every credential_id references a credential query, as the wallet does, and that the credential_ids of each transaction data are a "Non-empty array" (ibid.), which merging them into one set would hide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9886aba to
6eed651
Compare
Builds upon #803 to deprecate our old API, that relied on several assumptions and was in general not fit to capture the complexity of DCQL queries.