Repository navigation
🧪 Test Finder PDF double-click open-event delivery - #68
Merged
Merged
Conversation
Compile and launch a disposable, explicitly targeted PDF opener using macOS Launch Services, verify the native scan-gate receipt and original Unicode path, and assert the system PDF association remains unchanged. Document the separate literal Finder double-click procedure. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Retain newly merged PDF-handler registration, detection, and cold-browser tests while adding the Finder-style Launch Services event integration check. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Launch Services can decompose macOS file URL paths. Assert the delivered PDF has the same filesystem identity and Unicode-equivalent filename as the original request. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Include concurrently merged PDF-handler history and CI tests while keeping the Finder-style Launch Services event regression. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement checklist opener-0119 (§2.4, Test double-clicking PDFs in Finder) with a focused, non-destructive macOS integration test and a separate manual Finder walkthrough.
/usr/bin/open -a <temporary-app> <PDF>, which routes through macOS Launch Services and its open-documents Apple event. This tests actual native application dispatch rather than callingNSApplicationDelegate.application(_:open:)directly.Dependencies and scope
The existing native opener in
brave-pdf-opener.swiftalready handlesapplication(_:open:), duplicate suppression, and native scan progress. The existing native test calls that delegate directly; this PR adds real Launch Services event-delivery coverage. It does not overlap parallel default-PDF-handler action and verification PRs #62, #63, or #65 and does not mutate system-wide defaults.Validation
The commit tree differs from its parent and changes only one test script, the CI workflow, the README pointer, and the manual checklist. Require successful
scanner-testsandmacos-buildon the final integrated head before squash-merging.A clean local checkout was attempted, but GitHub DNS resolution is unavailable in the container. The work was therefore implemented in an isolated branch through the connected GitHub account (
JFWooten4); GitHub Actions supplies macOS runtime verification.