Repository navigation
🧪 Test PDFs through Finder's Open command - #69
Merged
Merged
Conversation
Add a Finder AppleScript Open integration probe, gated to interactive macOS with the PDF Magic Opener default already configured. Verify read-only default-handler preflight, source-file and origin-log safeguards, and Finder attribution, with AppleScript compilation in macOS CI. Preserve existing scanner, quarantine, and user associations. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Preserve the concurrent PDF handler verification work on main and retain only the Finder Open integration probe, documentation, and scoped CI checks. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Preserve current default-handler implementation and its checks; carry forward only the focused Finder Open probe, CI, and documentation. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Member
Author
|
Final verification: GitHub Actions run 40596763741 succeeded on head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement opener-0120 (§2.4 macOS default PDF handler): test opening PDFs through Finder's Open command, rather than treating a direct delegate call as equivalent.
test-finder-open.applescript, which issues Finder's realopenAppleScript verb against a separately supplied PDF path. Paths are passed as script arguments, never embedded into script source or a shell.test-finder-open.pywith deterministic tests of the read-only macOS default-handler preflight, valid local PDF selection, Finder command source, and newly appended anonymous Finder scan-origin records.--live /path/to/harmless.pdfintegration mode for an interactive Mac. It requires PDF Magic Opener already be the macOS default PDF handler, sends Finder the Open request, and verifies the normal scanner entry point receives a Finder-attributed request without changing file associations, bypassing scanning, or reading the user's PDF.Scope and coordination
Used a fresh isolated no-slash branch
peachbottom-finderopen120from verifiedmainfe58a76c68615cea36b8ad0122495ac289609d5c. Confirmed no applicableAGENTS.mdin the tracked tree and checked existing PRs for overlaps. The existing native tests simulate delegate events; this PR is the focused Finder Open integration path, separate from browser cold-start, default-handler monitoring, and other concurrent tasks.Only four test, documentation, and CI files changed; no runtime launcher, scanner, installation, quarantine, application-selection, or user-preference code was modified. Both
scanner-testsandmacos-buildare required green before authorized squash merge.Verification