Repository navigation
🔎 Detect changes to the default PDF handler - #65
Merged
Merged
Conversation
Compare each read-only Launch Services PDF-handler lookup with the PDF Magic Opener bundle identity, returning separate statuses for unchanged, takeover, and unknown registrations. Add native tests and installer/CLI documentation. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Preserve the merged read-only status command and its CI/installer/docs changes alongside the distinct takeover detection exit statuses and native tests. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement opener-0114 (§2.4, Detect when another application becomes the default PDF handler).
detect-pdf-handler-changeutility that compares the macOS Launch Services PDF handler against PDF Magic Opener's installed bundle identifier.registeredPDFHandlerBundleIdentifier()lookup already merged in PR #59, rather than duplicating the native handler-query logic or using the unrelated default web browser.Why
The installed
set-pdf-default-handler.swiftcan register the opener and the mergedidentify-pdf-handler.swiftcan report the current PDF handler, but no existing command distinguishes opener still default from another application has become default. This focused change provides that distinction without silently reverting user customizations.Verification
macos-buildCI job; keepscanner-testsunchanged.merged=true.Scope and preservation
Only the PDF default-association detection is changed. There are no changes to ClamAV, quarantine, scanner caching, user-selected browsers, opener association registration, fallback behavior or user's PDF settings. No secret-bearing files were accessed. The isolated branch is
pdf-handler-takeover. The available GitHub connection publishes as JFWooten4; no alternate identity or credentials were accessed.