Repository navigation
🔩 Add an explicit action to make PDF Magic Opener the default - #63
Merged
Merged
Conversation
Install a Finder-invokable action that verifies the PDF Magic Opener bundle before explicitly selecting it as the macOS default PDF handler. Keep the configured post-scan browser and scanner safety unchanged, preserve existing user-managed action files, and cover both the native logic and installation wiring in CI. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Create distinct temporary application bundles for identity, executable, document-type, and symlink validation to avoid mutating or caching the successful fixture. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Preserve the newly merged PDF handler inspection and running-browser safeguards while integrating the explicit user action to restore PDF Magic Opener as the default. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Invoke NSWorkspace.setDefaultApplication using its supported trailing completion closure, preserving the injectable success/failure handling and explicit user action. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Keep newly merged PDF handler status reporting and fallback selection alongside the explicit verified Finder default-handler action. Co-authored-by: ChatGPT # 6 <noreply@openai.com>
Member
Author
|
The first full CI run found a native Swift completion-handler argument error, which has been fixed without changing the feature's scope. Both Linux and macOS jobs then passed on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement opener-0110, checklist §2.4 macOS default PDF handler — Add a user action to make PDF Magic Opener the default.
~/Applications, and document the equivalent Terminal invocation.PDF Magic Opener.appbundle name, exactlocal.studio.brave-pdf-openeridentity, executable, and PDF document declaration before asking macOS to register it as the preferred PDF handler..commandfile on reinstall. Do not change the user's selected post-scan browser, other file associations, ClamAV scanning, quarantine, or content checks.Why
Installation already sets PDF Magic Opener as the PDF default, but if another app takes over later there has been no dedicated opt-in user action to restore it. The new action is reachable from Finder and Terminal, without requiring a PDF scan or a reinstall. It is independent of the separate generic utility rename PR #57 and read-only default handler inspection PR #59, and does not duplicate their scopes. The separate post-registration verification checklist work in PR #62 is also not modified.
Tests and CI
scanner-testsandmacos-buildmust both pass before squash merge.Publishing
The configured Codex Pony/Kefania publishing tool is not exposed in this chat. The connected GitHub identity is
JFWooten4; no credentials or secret-bearing files are accessed.