Repository navigation
Fix demo app bugs - #56
Merged
Merged
Conversation
- Identify: the visitor ID key used the slug js-sdk instead of the configured android-sdk, so the visitor ID always printed "null". - Kotlin: drop the ca.edge host so both demos use the SDK default (na.edge.optable.co), like the Java demo. - Kotlin: add the Prebid tab to the top-level AppBarConfiguration. - Prebid: clear the global ORTB config when targeting has no or a blank openRtbJson, so a previous result doesn't stick. - Prebid: log witness events as PrebidBannerFragment, not GAMBannerFragment, and say "from cache" on a cache hit (Java). - Remove unused string resources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosherBT
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The demo apps had a few bugs that make them misleading as reference integrations: the Identify tab always showed "Visitor ID: null", the Kotlin demo talked to a different host than the Java one, and the Prebid fragments could keep a stale ORTB config and logged their witness events under the GAM fragment's name.