Repository navigation
Update demo app dependencies - #57
Merged
Merged
Conversation
- Pin the release SDK to v1.2.0 instead of 1.0.0. - Java: replace Guava's Lists.newArrayList, which only reached the demo through Prebid's dependencies, with Arrays.asList. - Use androidx.preference's PreferenceManager instead of the deprecated android.preference one, and declare preference 1.2.1 explicitly. - Remove the multidex support library and multiDexEnabled (multidex is built in from API 21; minSdk is 23) and the unused constraintlayout. - Navigation 2.1.0 -> 2.8.9, compileSdk 34 -> 35, and test dependencies aligned with the SDK. targetSdk stays 34 (35 forces edge-to-edge). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosherBT
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The demo apps pinned the release SDK to
1.0.0, used Guava without declaring it, used the deprecatedandroid.preference.PreferenceManager, and carried 2019-era dependencies, including the pre-AndroidX multidex support library and an unused ConstraintLayout.