Skip to content

fix(deps): require weave>=0.54.0 for OpenTelemetry 1.45 exporters - #1159

Merged
Kovbo merged 1 commit into
mainfrom
fix/weave-otel-floor
Nov 4, 2026
Merged

Kovbo merged 1 commit into
mainfrom
fix/weave-otel-floor

Conversation

@Kovbo

@Kovbo Kovbo commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

weave.init() fails with AttributeError: 'OTLPSpanExporter' object has no attribute '_session' when Weave 0.53.9 or earlier runs alongside opentelemetry-exporter-otlp-proto-http 1.45. Those Weave releases read a private exporter attribute that OpenTelemetry 1.45 removed. Weave 0.54.0 includes the upstream fix.

ART's weave>=0.52.41 floor was satisfied by an existing older Weave, so installing ART into a reused kernel kept the broken version. The ART notebooks hit this failure (OpenPipe/art-notebooks#28 works around it by pinning Weave in every notebook). Raising the floor fixes it for all ART installs, so the notebooks can depend on an ART release and drop that pin.

Changes

  • weave>=0.52.41 → weave>=0.54.0 in pyproject.toml.
  • uv.lock: only Weave changes (0.52.41 → 0.54.0, plus its new distro, requests, and sniffio dependency entries, which were already locked).

Test plan

  • Control: installed openpipe-art==0.5.23 into an environment with weave==0.53.9 and exporter 1.45.2. Weave stayed at 0.53.9, and exporting a span through Weave's conversation tracing raised the reported _session AttributeError.
  • Same starting environment, installing this branch: uv upgraded Weave to 0.54.0, and real protobuf spans exported to a local OTLP HTTP receiver for two projects in sequence.
  • import art and weave.trace.settings.override_settings, ART's only direct Weave API, work on 0.54.0.
  • uv lock --check passes.
  • Unit tests and ty in CI. Locally on macOS the unit tests can't collect without torch, and ty reports only the existing Linux-only os.pidfd_open and os.sched_getaffinity diagnostics.

Weave 0.53.9 and earlier read OTLPSpanExporter._session, which
opentelemetry-exporter-otlp-proto-http 1.45 removed, so weave.init()
raises AttributeError. ART's weave>=0.52.41 floor let an environment
that already had such a Weave keep it.
@Kovbo
Kovbo marked this pull request as ready for review November 4, 2026 20:35
@Kovbo
Kovbo merged commit cf36a44 into main Nov 4, 2026
4 checks passed
@Kovbo Kovbo mentioned this pull request Nov 4, 2026
1 of 2 tasks
Kovbo added a commit that referenced this pull request Nov 4, 2026
#1159 raised ART's Weave floor to 0.54.0, but the release install
smoke test still added weave==0.52.41, which no longer resolves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant