Repository navigation
fix(deps): require weave>=0.54.0 for OpenTelemetry 1.45 exporters - #1159
Merged
Merged
Conversation
Weave 0.53.9 and earlier read OTLPSpanExporter._session, which opentelemetry-exporter-otlp-proto-http 1.45 removed, so weave.init() raises AttributeError. ART's weave>=0.52.41 floor let an environment that already had such a Weave keep it.
Kovbo
marked this pull request as ready for review
November 4, 2026 20:35
1 of 2 tasks
Kovbo
added a commit
that referenced
this pull request
Nov 4, 2026
#1159 raised ART's Weave floor to 0.54.0, but the release install smoke test still added weave==0.52.41, which no longer resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weave.init()fails withAttributeError: 'OTLPSpanExporter' object has no attribute '_session'when Weave 0.53.9 or earlier runs alongsideopentelemetry-exporter-otlp-proto-http1.45. Those Weave releases read a private exporter attribute that OpenTelemetry 1.45 removed. Weave 0.54.0 includes the upstream fix.ART's
weave>=0.52.41floor was satisfied by an existing older Weave, so installing ART into a reused kernel kept the broken version. The ART notebooks hit this failure (OpenPipe/art-notebooks#28 works around it by pinning Weave in every notebook). Raising the floor fixes it for all ART installs, so the notebooks can depend on an ART release and drop that pin.Changes
weave>=0.52.41→weave>=0.54.0inpyproject.toml.uv.lock: only Weave changes (0.52.41 → 0.54.0, plus its newdistro,requests, andsniffiodependency entries, which were already locked).Test plan
openpipe-art==0.5.23into an environment withweave==0.53.9and exporter 1.45.2. Weave stayed at 0.53.9, and exporting a span through Weave's conversation tracing raised the reported_sessionAttributeError.import artandweave.trace.settings.override_settings, ART's only direct Weave API, work on 0.54.0.uv lock --checkpasses.tyin CI. Locally on macOS the unit tests can't collect without torch, andtyreports only the existing Linux-onlyos.pidfd_openandos.sched_getaffinitydiagnostics.