Repository navigation
ci: smoke-test the new weave>=0.54.0 floor - #1162
Merged
Merged
Conversation
#1159 raised ART's Weave floor to 0.54.0, but the release install smoke test still added weave==0.52.41, which no longer resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1159 raised ART's Weave floor to
weave>=0.54.0. The release install smoke test (package-install.yml, which runs only onrelease/branches) still addsweave==0.52.41to check that ART imports with its minimum Weave. That pin no longer resolves, soinstall-smoke-testfails on the v0.5.24 release PR (#1160):Changes
weave==0.54.0, the new minimum.Test plan
scripts/build_package.py --wheeland ran the "Smoke test base wheel import" step's Weave commands locally:uv add "weave==0.54.0", thenfrom weave.trace.settings import override_settings; import artsucceeds.install-smoke-teston Release v0.5.24 #1160 after this merges.