Repository navigation
macOS: menu bar tray, link fix, macOS CI build; faster ci profile - #25
Conversation
- build.rs: only pass /STACK to MSVC targets (broke linking on macOS) - tray: macOS menu bar icon, shared with the Windows implementation - CI: macOS build workflow producing an ad-hoc-signed .dmg - CI: new 'ci' cargo profile (no LTO) used by PR/main builds
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 46.15% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files. (3 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the main changes: macOS tray support, the linker fix, the macOS CI build, and the faster CI profile. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 46.15% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| # substitute for a Developer ID signature and notarization. | ||
| codesign --force --deep --sign - "$app" | ||
|
|
||
| hdiutil create -volname "OpenMouse" -srcfolder "$app" -ov -format UDZO "$out/OpenMouse.dmg" >/dev/null |
There was a problem hiding this comment.
🟠 High scripts/make-macos-app.sh:50
The mounted DMG contains Contents/ at its root instead of an OpenMouse.app bundle, so users cannot drag the app into Applications or launch it from the image. hdiutil -srcfolder copies the source directory's contents to the volume root; stage the bundle inside a separate directory and use that directory as -srcfolder.
-hdiutil create -volname "OpenMouse" -srcfolder "$app" -ov -format UDZO "$out/OpenMouse.dmg" >/dev/null
+mkdir "$work/dmg-root"
+cp -R "$app" "$work/dmg-root/"
+hdiutil create -volname "OpenMouse" -srcfolder "$work/dmg-root" -ov -format UDZO "$out/OpenMouse.dmg" >/dev/null🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @.github/scripts/make-macos-app.sh around line 50:
The mounted DMG contains `Contents/` at its root instead of an `OpenMouse.app` bundle, so users cannot drag the app into Applications or launch it from the image. `hdiutil -srcfolder` copies the source directory's contents to the volume root; stage the bundle inside a separate directory and use that directory as `-srcfolder`.
There was a problem hiding this comment.
The fix is being prepared.
There was a problem hiding this comment.
make-macos-app.sh now copies the signed OpenMouse.app into a $work/dmg-root staging folder and builds the DMG from that folder, so OpenMouse.app sits at the root of the image. Before, -srcfolder "$app" put the bundle's contents at the root instead. The change is the suggested diff, applied verbatim; editor_check reported no errors, but the script hasn't been run on macOS.
Commit ad41e16 pushed to #26. When checks pass, it will merge automatically into this PR.
There was a problem hiding this comment.
I couldn't automatically merge #26 because the merge status is unstable.
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — The PR adds production-facing macOS menu-bar tray support and changes existing close and auto-start behavior, while also introducing a new platform-specific runtime dependency. The CI and DMG packaging changes are contained, and the reported DMG layout issue is fixed in the reviewed head, but the new user-facing lifecycle behavior warrants human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
(via snekxs): Put OpenMouse.app at the root of the macOS DMG
Note
Add macOS tray support, OpenMouse.dmg packaging, and faster
cibuild profileNSApplicationhide/unhide for visibility. The Windows code moves into a platform submodule and the public tray API now covers Windows and macOS, with a no-op hide on other targets.ciprofile, packages the DMG, and uploads it as an artifact.ciCargo profile in Cargo.toml that keeps release settings but disables LTO and uses 16 codegen units for faster CI builds. Windows installers now embed theci-profile GPUI executable while the installer itself stays on release./STACKlinker argument only for MSVC targets, and removes the Windows-only guard on the login-launch tray hide in main.rs.ci-profile (no LTO) GPUI binary instead of a release-profile one.Macroscope summarized 104f8b5.
Summary by CodeRabbit