Skip to content

(via snekxs): Put OpenMouse.app at the root of the macOS DMG - #26

Merged
snekxs merged 1 commit into
macos-supportfrom
macroscope/macos-support
Oct 22, 2026
Merged

snekxs merged 1 commit into
macos-supportfrom
macroscope/macos-support

Conversation

@macroscopeapp

@macroscopeapp macroscopeapp Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes the macOS DMG layout so that OpenMouse.app sits at the root of the disk image.

Changes

  • make-macos-app.sh now copies the signed OpenMouse.app into a staging folder at $work/dmg-root, then builds the DMG with that folder as -srcfolder.
  • Before this change, -srcfolder "$app" was used. That put the bundle's contents at the root of the image, not the OpenMouse.app bundle itself.

Notes for reviewers

  • The change is the suggested diff, applied verbatim.
  • editor_check reported no errors, but the script has not been run on macOS. Before merging, please build a DMG, mount it, and check that OpenMouse.app is at the root of the volume and that its code signature is still valid after the copy.

Note

Macroscope: Fix It For Me

Activity

Currently: Merged by snekxs

Previously
  • Not merged: unstable
  • Waiting on checks
  • Pushed ad41e16

Note

Put OpenMouse.app at the root of the macOS DMG

Updates make-macos-app.sh to copy the signed app bundle into a staging directory and build the DMG from there. The DMG now contains the OpenMouse application bundle as an item at its root, instead of the bundle directory's contents.

Macroscope summarized ad41e16.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9809c431-8ae2-4c2f-90de-112ae83cbe2c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp
macroscopeapp Bot requested a review from snekxs October 22, 2026 07:27
@snekxs
snekxs merged commit 104f8b5 into macos-support Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant