Repository navigation
(via snekxs): Put OpenMouse.app at the root of the macOS DMG - #26
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS DMG layout so that
OpenMouse.appsits at the root of the disk image.Changes
make-macos-app.shnow copies the signedOpenMouse.appinto a staging folder at$work/dmg-root, then builds the DMG with that folder as-srcfolder.-srcfolder "$app"was used. That put the bundle's contents at the root of the image, not theOpenMouse.appbundle itself.Notes for reviewers
editor_checkreported no errors, but the script has not been run on macOS. Before merging, please build a DMG, mount it, and check thatOpenMouse.appis at the root of the volume and that its code signature is still valid after the copy.Note
Macroscope: Fix It For Me
Activity
Currently: Merged by snekxs
Previously
Note
Put OpenMouse.app at the root of the macOS DMG
Updates make-macos-app.sh to copy the signed app bundle into a staging directory and build the DMG from there. The DMG now contains the OpenMouse application bundle as an item at its root, instead of the bundle directory's contents.
Macroscope summarized ad41e16.