Skip to content

feat(service-map): show Google Cloud as the platform for services on GCP - #1495

Closed
JeremyFunk wants to merge 2 commits into
feat/gcp-infra-pagefrom
feat/gcp-service-map-hosting
Closed

feat(service-map): show Google Cloud as the platform for services on GCP#1495
JeremyFunk wants to merge 2 commits into
feat/gcp-infra-pagefrom
feat/gcp-service-map-hosting

Merge remote-tracking branch 'origin/feat/gcp-infra-page' into feat/g…

d0db410
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 15, 2026 in 2m 14s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
Contained; both classifier copies and the icon move agree, and the local-ui test pins the new order. The GCP fix assumes gcpDetector emits cloud.provider.
quality 100/100 · no findings · tests partial · risk medium

Adds a gcp platform to the service map, checked before the Lambda and Kubernetes rules, with a Google Cloud icon, colour and legend entry. Small, consistent across the API and local-ui classifiers; safe to merge.

  • toServicePlatformRow and classifyPlatform classify cloud.provider = gcp before Lambda and Kubernetes
  • ServicePlatform gains gcp in the domain wire schema and both TypeScript unions
  • GoogleCloudIcon moved to @maple/ui, re-exported from @/components/icons
  • Platform legend uses fixed labels; PLATFORM_COLORS gains a Google Cloud colour
What was checked
  • Both classifier copies apply the gcp rule in the same position (query-engine.http.ts:263, use-local-service-map.ts:111)
  • google-cloud.tsx resolves ./icon in packages/ui; no remaining import of the old @/components/icons/google-cloud path
  • Every platform switch is exhaustive (satisfies Record<ServicePlatform | "unknown", string>, getPlatformIcon), so the new member cannot silently fall through

d0db410 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot