Repository navigation
feat(service-map): show Google Cloud as the platform for services on GCP - #1495
JeremyFunk wants to merge 2 commits into
Conversation
…ted on GCP Google Cloud's resource detector sets faas.name on Cloud Run and Cloud Functions, so those services were drawn as AWS Lambda, and GKE services as plain Kubernetes. cloud.provider=gcp now classifies as a gcp platform with the Google Cloud mark, tooltip, colour and legend entry.
Maple review🟢 Confidence 8/10 · likely safe to merge Adds a
What was checked
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cp-service-map-hosting
Maple review🟢 Confidence 9/10 · safe to merge Adds a
What was checked
|
Stacked on #1336.
Services on Google Cloud did not read as Google Cloud on the service map:
gcpDetectorour GCP docs recommend setsfaas.name, so the classifier called themlambdaand drew the AWS Lambda icon.Change:
cloud.provider = gcpclassifies as a newgcpplatform, checked before the Lambda and Kubernetes rules (API classifier and the local-ui copy).capitalize).GoogleCloudIconmoved fromapps/webinto@maple/uiicons (re-exported from@/components/icons, so existing imports keep working).Tested: local-ui classifier test (Cloud Run + GKE cases),
packages/uiservice-map tests; rendered on/lab/bench/service-mapin platform colour mode (icon, tooltip, legend).Need help on this PR? Tag
@codesmith-botwith what you need.