Skip to content

feat(billing): price product events at $5 per million after 1M included - #1486

Open
Makisuo wants to merge 2 commits into
mainfrom
feat/product-events-pricing
Open

feat(billing): price product events at $5 per million after 1M included#1486
Makisuo wants to merge 2 commits into
mainfrom
feat/product-events-pricing

fix(landing): quote an events rate in the FAQ only when the catalog p…

1958df1
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 15, 2026 in 1m 41s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
The FAQ now keys off the catalog before quoting a price; the per-million quote math is pinned by the updated billing tests.
quality 100/100 · no findings · tests partial · risk medium

Prices product events at $5 per million after 1M included, quoting the rate per million across the landing page, the in-app plan cards and the billing estimate. The last commit's FAQ guard removes the "$0 per million" text; safe to merge.

  • pricingFaq quotes an events rate only when the catalog prices it, else keeps the beta sentence
  • pricing-offer normalizes an events rate to a 1M quote block
  • quoteUnits/formatQuoteUnits in apps/web render "$5/1M events"

Fixed since the last review

  • ✅ F1 · Pricing FAQ quotes $0 per million while the catalog still has events unlimited
What was checked
  • F1: pricing-faq.ts:32-35 falls back to faq_events_beta for an unlimited or unpriced events item, so no $0 quote
  • Events quote math: (0.005/1000)*1e6 = 5 in pricing-offer.ts:158, cost-estimate.ts:148, spend.ts:94, matching the updated billing tests
  • en/ja/ko message files parse and keep their key sets; ja/ko lack all faq_* keys by existing convention (1175 vs 1274), so Paraglide's base-locale fallback covers the two new messages

1958df1 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot