Skip to content

Prevent ADMIN_KEY envar from recreating existing auth key #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ostefano merged 3 commits into from
Oct 9, 2026
Merged

Prevent ADMIN_KEY envar from recreating existing auth key #444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebcb25e
Prevent resetting existing admin_key
jeremiah-RENISAC Sep 9, 2026
6990cf8
Fix indenting
jeremiah-RENISAC Sep 9, 2026
d23dee5
Fix indentation in configure_misp.sh
jeremiah-RENISAC Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions core/files/configure_misp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,19 +477,25 @@ init_user() {
fi

if [ -n "$ADMIN_KEY" ]; then
if [ "$DISABLE_PRINTING_PLAINTEXT_CREDENTIALS" == "true" ]; then
echo "... setting admin key from environment variable"
ADMIN_KEY_ALREADY_SET=$($MYSQL_CMD -N -s -e 'SELECT authkey FROM auth_keys WHERE user_id = 1 AND (expiration = 0 OR expiration > UNIX_TIMESTAMP());' |
php -r '$match = false; while (($hash = fgets(STDIN)) !== false) { $match = $match || password_verify(getenv("ADMIN_KEY"), trim($hash)); } echo (int) $match;')
if [ "$ADMIN_KEY_ALREADY_SET" = "1" ]; then
echo "... configured admin key already active, not changing"
else
echo "... setting admin key to '${ADMIN_KEY}'"
if [ "$DISABLE_PRINTING_PLAINTEXT_CREDENTIALS" == "true" ]; then
echo "... setting admin key from environment variable"
else
echo "... setting admin key to '${ADMIN_KEY}'"
fi
CHANGE_CMD=(sudo -u www-data /var/www/MISP/app/Console/cake User change_authkey 1 "${ADMIN_KEY}")
fi
CHANGE_CMD=(sudo -u www-data /var/www/MISP/app/Console/cake User change_authkey 1 "${ADMIN_KEY}")
elif [ -z "$ADMIN_KEY" ] && [ "$AUTOGEN_ADMIN_KEY" == "true" ]; then
HAS_VALID_KEY=$($MYSQL_CMD -N -s -e 'SELECT EXISTS(SELECT 1 FROM auth_keys WHERE user_id = 1 AND (expiration = 0 OR expiration > UNIX_TIMESTAMP()));')
if (( HAS_VALID_KEY == 0 )); then
if (( HAS_VALID_KEY == 0 )); then
echo "... regenerating admin key (set \$ADMIN_KEY if you want it to change)"
CHANGE_CMD=(sudo -u www-data /var/www/MISP/app/Console/cake User change_authkey 1)
else
echo "... valid admin key for admin user found, not changing"
else
echo "... valid admin key for admin user found, not changing"
fi
else
echo "... admin user key auto generation disabled"
Expand Down
Loading