Repository navigation
Prevent ADMIN_KEY envar from recreating existing auth key - #444
Merged
Merged
Conversation
Contributor
Author
|
Tested the new image:
|
Collaborator
|
@righel can you help reviewing this? |
ostefano
added
enhancement
Contributor
Author
Any word on getting this reviewed? |
Contributor
|
LGTM. There is an indentation issue staring in line 491, if you could fix that it would be great. Thanks. |
righel
reviewed
Oct 8, 2026
righel
requested changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443
Adds a check when the environment variable "ADMIN_KEY" is set to see if user 1's key is already set to the same value by hash match, and if so, skips the change_authkey command. When change_authkey is run, it expires the current key and recreates a new duplicate entry without preserving any allowed ips.