Skip to content

bitcoind: prefer coinbasetxn when a template also has coinbasevalue #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asilgulsar1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bitcoind: prefer coinbasetxn when a template also has coinbasevalue #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/bitcoind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,10 @@ int bitcoind_parse_template(void *result_json,
copy_hex64(t->prev_hash_hex, jp->valuestring);
copy_hex64(t->target_hex, jt->valuestring);

if (has_value) {
/* BIP22 lets a template carry both. A server that ships its own coinbase
* (the CUSF enforcer) puts mandatory outputs in it, so building our own
* from coinbasevalue would drop them: coinbasetxn always wins. */
if (has_value && !has_cbtxn) {
t->coinbase_value_sats = (int64_t)jc->valuedouble;
} else {
/* coinbasetxn: keep the raw coinbase hex; the value is reported as a
Expand Down
16 changes: 16 additions & 0 deletions tests/test_bitcoind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,21 @@ static void test_parse_coinbasetxn(void) {
cJSON_Delete(root);
}

/* BIP22 allows both fields. The server's coinbase carries mandatory outputs
* (drivechain commitments), so it must win over building our own. */
static void test_parse_prefers_coinbasetxn(void) {
cJSON *root = cJSON_Parse(SAMPLE_GBT_COINBASETXN);
assert(root);
cJSON_AddNumberToObject(root, "coinbasevalue", 1234);
bitcoind_template_t *t = NULL;
char err[256] = {0};
CHECK(bitcoind_parse_template(root, &t, err, sizeof(err)) == 0);
CHECK(t != NULL && t->coinbasetxn_hex != NULL);
CHECK(t != NULL && t->coinbase_value_sats == 5000000000LL);
bitcoind_template_free(t);
cJSON_Delete(root);
}

static void test_parse_missing_prevhash(void) {
const char *bad =
"{ \"version\":1, \"coinbasevalue\":100, \"target\":\"00\","
Expand Down Expand Up @@ -459,6 +474,7 @@ static void test_getblockhash_returns_the_hash(void) {
int main(void) {
test_parse_ok();
test_parse_coinbasetxn();
test_parse_prefers_coinbasetxn();
test_parse_missing_prevhash();
test_parse_empty_txs();
test_double_free_safe();
Expand Down