Repository navigation
bitcoind: prefer coinbasetxn when a template also has coinbasevalue - #103
Open
asilgulsar1 wants to merge 1 commit into
Open
asilgulsar1 wants to merge 1 commit into
asilgulsar1 wants to merge 1 commit into
Conversation
BIP22 allows a template to carry both. bitcoind_parse_template took coinbasevalue whenever it was present and never stored coinbasetxn, so the pool built its own coinbase with only the witness commitment: every BIP300/301 commitment output in the server's coinbase was dropped, and every block mined on such a template is invalid on a drivechain chain. The server-provided coinbase now always wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run simplepool in solo mode for eCash.com (ECX, BIP300/301) behind the CUSF enforcer. These came out of a review of the solo path before we rely on it.
BIP22 allows a template to carry both
coinbasevalueandcoinbasetxn.bitcoind_parse_templatetookcoinbasevaluewhenever present and never storedcoinbasetxn, so the pool built its own coinbase with only the witness commitment, dropping every BIP300/301 commitment output. Every block on such a template would be invalid on a drivechain chain. The enforcer sends onlycoinbasetxntoday, so this is latent, but it is one field away. Nowcoinbasetxnalways wins.Test:
test_parse_prefers_coinbasetxn.Tested:
make testpasses on this branch alone, and the new test fails onmainwithout the fix. This PR is independent of the five others opened alongside it, and all six merge together cleanly. Happy to add a CHANGELOG entry if you'd like one.🤖 Generated with Claude Code