Repository navigation
Quarantine the reviewed mixed-strain BactoTraits row - #1867
Merged
realmarcin merged 5 commits intoNov 16, 2026
Merged
Conversation
realmarcin
deleted the
fix/bactotraits-identity-quarantine-130-20261115
branch
November 16, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The June 2022 BactoTraits row for BacDive 17851 combines the Rubritalea name with DSM 19353 / JCM 14586, which primary collection catalogs identify as Thioprofundum. The transform currently joins on BacDive alone and emits assertions from that mixed row.
Withhold this one reviewed row before graph emission, using a finite policy bound to the complete original record and mapped taxon. Preserve all original identity fields and hashes in a mandatory producer audit. Changed, missing or duplicate reviewed rows and conflicting lookups fail closed. No replacement organism or phenotype values are inferred, and unreviewed neighboring rows keep their prior behavior.
Actual v3 replay on the retained source row and real lookup produced 21 baseline assertions and 22 nodes, versus zero assertions/nodes and one complete original-row audit with the fix. The replay retains and consumes the same prefix registry and other mapping inputs, uses real read-only NCBITaxon label statements, and makes no provider calls. An independent reviewer verified the saved output/input/audit bytes. There were no unaffected real rows in the slice; a separate synthetic control tests retention. This is producer output before finalization, not a regenerated published graph or biological refutation.
Separate adversarial reviews passed the core correction, final replay helper and v3 evidence/documentation. Findings #1866 (import-time cache isolation) and #1868 (missing prefix-registry provenance) were filed, fixed and re-reviewed; failed/superseded evidence remains unchanged. Focused checks passed: 209 affected contract tests and five launcher regressions.
All final local gates passed at a86c63e: lock/config, formatting, lint, spelling, docstrings, and the complete suite (9,958 passed, 56 skipped). The gate ledger is
data/validation/pr-gates/kgm-bactotraits-identity-130-v3-20261116-gates.json, SHA256244280d073cc925e8183131b6a108bda726458b7550be0813c19fecc92ebc8c6, retained privately. The obsolete earlier gate was interrupted and is not passing evidence. All final-head Python 3.10/3.11/3.12 CI jobs passed in run 43827336706.Fixes #1865. Fixes #1866. Fixes #1868. Refs CultureBotAI/EdgeMech#130, CultureBotAI/EdgeMech#132 and CultureBotAI/EdgeMech#135. The neighboring-row investigation remains separate; no automatic expansion is included.