Repository navigation
fix(test): commit medical fixture before browser reload - #109
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main release gate on
463903f6c3139a674f2f982dd39fc54b123e45a3timed out waiting for Ivy Patch instaff-facility-medical. The failure page showed the original regular-season Week 14 save with no medical staff, rather than the staged offseason fixture.The successful PR #108 integration and failed main commit share the exact tree
787f2cba8dfca5ffda9818445ab0d8f28254c4a2. The scenario's IndexedDB helper resolved onputrequest success, before transaction commit, and immediately hard-reloaded. A controlled regression using the actual browser expression reproduces premature completion and false success after a subsequent abort. This supports an intermittent fixture commit race; the historical log did not record an abort, so that particular event remains inferred.Correction
Wait for the medical fixture transaction's
oncomplete, reject request/transaction failures, and close the connection on write failure. Add four behavioral regressions for commit ordering, abort after request success, transaction error, and request error. All existing candidate, facility level/effect/budget, hire/pool-return, hard-reload and browser-error assertions remain intact.Verification
28fd0ed3e01e1376fcd6de2affd5f14f26cf3ebb.8262621f19819b07adcadeef7bf3fcffbf3f8dd9. The integration commit3b0951c5a3676d7d86f9165743a03ec210548c8ehas the same tested source tree.No application, save/schema, gameplay, dependency, CI job, release-plan, or deployment changes. Reverting these two files restores the old test helper.
Failure evidence: https://github.com/KevinBigham/MFD/actions/runs/37723894338/job/113143484567
Passing identical-tree evidence: https://github.com/KevinBigham/MFD/actions/runs/37716671343/job/113123157060
Main validation
Merged as
d617b691342b4bd552a43edc6a929150180f635b; its tree matches the successful PR integration and locally tested correction exactly. Main CI run 37817114932 is pending. Pages remains gated on successful completion of that main run.