Skip to content

fix(test): commit every staged browser fixture before reload - #111

Merged
KevinBigham merged 1 commit into
mainfrom
codex/mfd-fixture-transaction-barriers-20261008
Oct 8, 2026
Merged

KevinBigham merged 1 commit into
mainfrom
codex/mfd-fixture-transaction-barriers-20261008

Conversation

@KevinBigham

@KevinBigham KevinBigham commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Main CI 37817114932, after #109, passed tests and determinism but failed G3 free-agency-signings waiting for “Re-Sign Window.” The browser retained the original regular-season save. Pages 37826944917 was skipped.

The free-agency fixture has the same IndexedDB completion race as the original staged-medical timeout: a successful put request can precede transaction commit, allowing the subsequent reload to abort the write. Controlled execution of the actual browser fixture expression reproduces premature completion and an ignored abort. The historical logs do not record the transaction abort directly, so that event is inferred; the fixture synchronization defect is reproduced.

Use one self-contained transaction writer at all eight existing staged-save write sites in the G3 browser script. It returns generated slot IDs only on transaction.oncomplete, rejects write/transaction failures, and closes the connection afterward. Medical behavior from #109 is retained. Save payloads, scenario assertions, reloads, timeouts, application code, CI jobs, and the full release plan are unchanged.

Validation:

  • Four new free-agency regressions fail before the correction: re-sign, open-market, and street-sign fixtures must wait for commit; an abort after request success must reject.
  • Existing medical transaction regressions remain enabled.
  • All 87 local script/release-contract tests pass; syntax and whitespace checks pass.
  • Required independent review approved the change; its separate 78-test subset passes.
  • PR CI 37829769749, attempt 1, passed all required jobs: test, determinism-gate, and release-gate.
  • The test job passed 4,854 tests across 534 files. The full public-release gate passed all 37 checks in 2,603.6 seconds, including all 15 G3 scenarios. Free-agency signings passed in 9.5 seconds and staff/facility/medical in 6.9 seconds, retaining all staged-save and result hard reloads with no browser errors.
  • The tested PR integration tree and merged main tree match the reviewed head tree (2da2e5b10177bcb92648c1cfa1e47a75aa0bfd9c).
  • Merged as 49bcd4d01888bc6d077294dbe795ddac76800a38. Main CI 37838604142, attempt 1, passed all three required jobs: 4,854 tests, determinism, and all 37 full-release checks in 2,591.0 seconds. All 15 G3 scenarios passed; free agency took 9.5 seconds and medical 6.7 seconds with their hard-reload assertions intact.
  • Pages 37848619696 succeeded only after that main CI. Its package log confirms artifact mfd-pages-49bcd4d01888bc6d077294dbe795ddac76800a38 (ID 11580677026) came from run 37838604142; downloaded SHA-256 matched 32c288ad5860c73cf17ddd515b23cd067c2f44e1b0d45106df4f5beb818e2ac9. The deployment used that exact commit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T19:10:42.037418Z a9ab363 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KevinBigham
KevinBigham merged commit 49bcd4d into main Oct 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant