Repository navigation
fix(test): commit every staged browser fixture before reload - #111
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI 37817114932, after #109, passed tests and determinism but failed G3
free-agency-signingswaiting for “Re-Sign Window.” The browser retained the original regular-season save. Pages 37826944917 was skipped.The free-agency fixture has the same IndexedDB completion race as the original staged-medical timeout: a successful
putrequest can precede transaction commit, allowing the subsequent reload to abort the write. Controlled execution of the actual browser fixture expression reproduces premature completion and an ignored abort. The historical logs do not record the transaction abort directly, so that event is inferred; the fixture synchronization defect is reproduced.Use one self-contained transaction writer at all eight existing staged-save write sites in the G3 browser script. It returns generated slot IDs only on
transaction.oncomplete, rejects write/transaction failures, and closes the connection afterward. Medical behavior from #109 is retained. Save payloads, scenario assertions, reloads, timeouts, application code, CI jobs, and the full release plan are unchanged.Validation:
test,determinism-gate, andrelease-gate.2da2e5b10177bcb92648c1cfa1e47a75aa0bfd9c).49bcd4d01888bc6d077294dbe795ddac76800a38. Main CI 37838604142, attempt 1, passed all three required jobs: 4,854 tests, determinism, and all 37 full-release checks in 2,591.0 seconds. All 15 G3 scenarios passed; free agency took 9.5 seconds and medical 6.7 seconds with their hard-reload assertions intact.mfd-pages-49bcd4d01888bc6d077294dbe795ddac76800a38(ID11580677026) came from run37838604142; downloaded SHA-256 matched32c288ad5860c73cf17ddd515b23cd067c2f44e1b0d45106df4f5beb818e2ac9. The deployment used that exact commit.