Skip to content

Signal lists: act on the design-critique review - #53

Merged
JanGradkowski merged 1 commit into
mainfrom
signal-lists-critique-fixes
Nov 12, 2026
Merged

JanGradkowski merged 1 commit into
mainfrom
signal-lists-critique-fixes

Conversation

@JanGradkowski

Copy link
Copy Markdown
Owner

Summary

These are follow-up fixes to #52 from a review of the merged signal list pages with the design:design-critique skill.

  • Phones: the figures band folds into one line (the results headline, or "Signals per day" / "Alerts per day"). Tapping it opens the charts, and the choice is remembered. Before, the first signal started about 1.1 screens down; now it is on the first screen.
  • Results still being measured (an open projection's current return) show in plain text instead of red or green, so only finished results read as gains or losses, as the guide's legend says. "Pending" is quieter.
  • Ticker alerts on phones: the trade date reads first and "filed …" second, as on wider screens.
  • Types menu: Show is an accent button again. The menu's item style had flattened it.
  • Tap targets on phones: stand-alone text links (How signals work, See them, best first, SEC filing ↗) get a hit area of about 40px, and the return's ⓘ is 36px. The layout doesn't change.

Red and green for direction words (Sale/Purchase, Sell/short) stay as they are: that's the usual trading convention, and the review rated it minor.

Checks

  • Screenshots in both themes at phone and desktop widths, plus Polish. The layout check finds no overlaps or overflow at 360, 390, 820 and 1440 px in English or Polish.
  • Contrast: all text in the list passes WCAG AA in both themes.
  • The phone band opens with the charts drawn full width (326 px), and the choice survives a reload.
  • node --test src/test/js/*.test.cjs: 146 passed
  • ./mvnw -o test: 1134 run, 0 failures, 33 skipped

🤖 Generated with Claude Code

A review of the signal list pages with the design-critique skill found
five things to change:

- Phones fold the figures band into one line ("8 of 20 finished
  higher", or "Signals per day") that opens the charts, so the list
  starts on the first screen. The choice is remembered.
- A result still being measured (an open projection's current return)
  is shown in plain text instead of red or green, so only finished
  results read as gains or losses. "Pending" is quieter.
- Ticker alerts on phones: the trade date reads first and "filed" second,
  as on wider screens.
- The Types menu's Show button is an accent button again; the menu's
  item style had flattened it.
- On phones, stand-alone text links (How signals work, See them, the
  filing link) and the return's (i) get a finger-sized hit area.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JanGradkowski
JanGradkowski enabled auto-merge (squash) November 12, 2026 13:19
@JanGradkowski
JanGradkowski merged commit 1f19886 into main Nov 12, 2026
2 checks passed
@JanGradkowski
JanGradkowski deleted the signal-lists-critique-fixes branch November 12, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants