Repository navigation
Signal lists: act on the design-critique review - #53
Merged
Merged
Conversation
A review of the signal list pages with the design-critique skill found
five things to change:
- Phones fold the figures band into one line ("8 of 20 finished
higher", or "Signals per day") that opens the charts, so the list
starts on the first screen. The choice is remembered.
- A result still being measured (an open projection's current return)
is shown in plain text instead of red or green, so only finished
results read as gains or losses. "Pending" is quieter.
- Ticker alerts on phones: the trade date reads first and "filed" second,
as on wider screens.
- The Types menu's Show button is an accent button again; the menu's
item style had flattened it.
- On phones, stand-alone text links (How signals work, See them, the
filing link) and the return's (i) get a finger-sized hit area.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are follow-up fixes to #52 from a review of the merged signal list pages with the
design:design-critiqueskill.Red and green for direction words (Sale/Purchase, Sell/short) stay as they are: that's the usual trading convention, and the review rated it minor.
Checks
node --test src/test/js/*.test.cjs: 146 passed./mvnw -o test: 1134 run, 0 failures, 33 skipped🤖 Generated with Claude Code