Skip to content

Rework the homepage after design-critique review; signal list and navigation fixes - #54

Merged
JanGradkowski merged 1 commit into
mainfrom
signal-lists-score-fixes
Nov 13, 2026
Merged

JanGradkowski merged 1 commit into
mainfrom
signal-lists-score-fixes

Conversation

@JanGradkowski

Copy link
Copy Markdown
Owner

Summary

The homepage was reworked over ten review rounds. In each round an independent judge reviewed fresh screenshots with the design:design-critique skill, and the findings were fixed before the next round. It went from 5.5/10 to 8.0–8.3/10. The branch also carries fixes to the signal lists from a scored follow-up review of #53, and two navigation changes that apply to every page.

Homepage

  • Status headline: the unread count with a linked breakdown: new signals and outlook changes, ticker alerts, and custom alert triggers. The counters panel is gone; the monitoring note is now a footnote.
  • Your stocks:
    • Sparklines are neutral, so red and green mean only the day's change. Their direction is announced to screen readers.
    • On phones the cards scroll sideways; from 1101px wide there are six to a row.
  • One row layout in every list: ticker and company with the date, the name, its detail, then the status.
    • Technical signals lead the detail line with the expected direction and show "Setup 78/100".
    • Outlook changes read "Neutral → Slight buy", with the new outlook coloured by direction, and "Outlook +14".
    • Custom alert rows say how many conditions matched. They say "Fired as soon as you saved it" only when that is what happened.
  • Actions under each list: Unread signals; Create and Manage watchlists; Unread triggers; Create and Manage custom alerts. On phones they stack, with tap areas that don't overlap.
  • Watchlists:
    • Each row shows its counts and an unread badge, with the number and word on one line.
    • A note says what the unread count includes.
  • Polish:
    • "Siła układu" for the setup score, "Ocena" for the outlook, and "zadziałały" for triggers.
    • Amounts read "249 280 $".
    • Officer titles are built per role (RoleTitles).
  • Naming: the page title, logo label and breadcrumbs say "Home".

Signal lists

  • Tables from 901px wide (cards below that). The select column and the Received column stay at zero width instead of being hidden, because hiding a column broke group headings and colspans in Chrome.
  • Widths: fixed widths for the result column, company names on up to two lines, and a short return header on narrow tables.
  • Types menu: it opens upward only when it fits below the header; otherwise the page scrolls to it.
  • Wording and status:
    • Results of custom triggers that are still being checked are marked as running.
    • A watchlist's trade words use the buy/sell colours.
    • Negative numbers use a true minus sign.

Navigation (all pages)

  • Skip link: a "Skip to content" link moves focus to the main content.
  • One row from 1025px: the top navigation stays on one row in both languages. It tightens step by step: tighter spacing, then icons only, then compact, then a second row.
  • Shorter Polish labels: "Sygnały", "Obserwowane oceny" and "Pomoc".

Checks

  • node --test src/test/js/*.test.cjs: 147 passed
  • ./mvnw test: 1140 run, 0 failures, 33 skipped
  • Layout check: no overlapping or spilling text and no sideways scrolling on the homepage at ten widths from 360 to 1440px, in English and Polish. Every tap on the controls checked lands on its own control.
  • Review: ten judge rounds, each confirmed in its transcript to have used design:design-critique. Scores: 5.5 → 7.3 → 7.3 → 8.2 → 7.0 → 8.2 → 8.3 → 8.0 → 8.3 → 8.0.

Still open from the last review, all minor:

  • Tabbing to a stock card on a phone leaves it partly out of view.
  • Outlook rows are one line taller than the others.
  • Panel subtitles come before their heading for screen readers.
  • On Polish phones, "Zapytaj" wraps onto its own row.
  • At 1440px the right column ends above the left one.

🤖 Generated with Claude Code

… navigation fixes

Homepage: a status headline with a linked unread breakdown, neutral
sparklines, one row layout across Latest signals, Watchlists and Custom
alerts, actions under each list, and Polish wording ("Siła układu",
"Ocena", "zadziałały", amounts as "249 280 $"). The counters panel is
gone and the monitoring note is a footnote.

Signal lists: tables from 901px with zero-width select and Received
columns (hiding a column broke colspans in Chrome), fixed result widths,
the Types menu flipping only when it fits, running custom-trigger results,
and true minus signs.

Navigation: a skip link, and the top bar stays on one row from 1025px by
tightening step by step; shorter Polish labels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JanGradkowski
JanGradkowski merged commit 3901fe2 into main Nov 13, 2026
2 checks passed
@JanGradkowski
JanGradkowski deleted the signal-lists-score-fixes branch November 13, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants