Skip to content

Give the signal lists the custom alert page's design - #52

Merged
JanGradkowski merged 1 commit into
mainfrom
signal-lists-design
Nov 12, 2026
Merged

JanGradkowski merged 1 commit into
mainfrom
signal-lists-design

Conversation

@JanGradkowski

Copy link
Copy Markdown
Owner

Summary

All signals (and a watchlist's), a stock's signals (/alerts/{id}) and All ticker alerts now use the custom alert page's design:

  • a header with a "How it works" guide;
  • a figures band;
  • tabs with counts and a ticker filter;
  • a sortable table;
  • Select with bulk delete;
  • keyboard shortcuts and a pager.

Filters, tabs and sorting stay links, so the server keeps paging large archives.

  • Figures come from the whole filtered archive: items per day, and for finished signals how many ended higher, the median and a dot per result. The code is in list-figures.js, shared with the custom alert page. Fewer than 5 results read as one line.
  • Filters:
    • Tabs: All, Unread, Active and Completed. Ticker alerts use All, Unread, Purchases and Sales.
    • A Types menu (Source on ticker alerts) and an order list at every width.
    • Chips that each remove one filter.
  • Status:
    • The setup score sits beside the status word.
    • Amber marks only patterns waiting for confirmation; a solid dot marks what is still measured and a ring what has finished. Gains and losses are coloured on the result.
    • Finished Elliott and harmonic plans say how they ended (Target reached, Stop breached, Not filled, …) instead of "Detected".
    • Harmonic trades that reached their target no longer read "Active stop".
  • Ticker alerts:
    • Each row shows the buyer or seller with their role and filing link, the trade and amount, and the traded and filed dates.
    • "Return in trade direction" has an ⓘ note. On phones the note is a line above the list.
  • Widths:
    • Tablets keep the table and show the time under the status.
    • Phones show each row as a card.
    • Tabs go two by two when a label (e.g. Polish "Nieprzeczytane") can't fit.
  • Server side:
    • Summary queries count the tabs and feed the figures.
    • The ticker alert archive filters by state, ticker and source.
  • Assistant pages describe the new layout.

Design review

An independent rater scored the pages from screenshots and the live review server: 6 → 6.5 → 7.5 → 8 → 8.5/10. Each round covered phone, tablet and desktop widths, both themes, and English and Polish. A layout check confirmed that nothing overlaps or overflows at 360, 390, 820 and 1440 px in either language.

Test plan

  • node --test src/test/js/*.test.cjs: 146 passed
  • ./mvnw -o test: 1134 run, 0 failures, 33 skipped
  • New ArchiveLinksTest covers the filter, sort and page URLs, and ArchiveQueryRegressionIntegrationTest covers the summary counts

🤖 Generated with Claude Code

All signals (and a watchlist's), a stock's signals (/alerts/{id}) and All
ticker alerts now share the custom alert page's layout: a header with a
"How it works" guide, a figures band, tabs with counts, a ticker filter,
a sortable table, Select with bulk delete, keyboard shortcuts and a
pager. Filters, tabs and sorting stay links, so the server keeps paging
large archives.

- Figures from the whole filtered archive: items per day and, for
  finished signals, how many ended higher, the median and a dot per
  result (list-figures.js, shared with the custom alert page; unchanged
  results are hollow dots). Too few results read as one line.
- Tabs All, Unread, Active and Completed (ticker alerts: All, Unread,
  Purchases, Sales), a Types menu (ticker alerts: Source), an order list
  at every width, and chips that remove one filter each.
- Status: the setup score sits beside the status word. Amber marks only
  patterns waiting for confirmation, a solid dot what is still measured,
  a ring what has finished; gains and losses are coloured on the result.
  Finished Elliott and harmonic plans say how they ended (Target reached,
  Stop breached, Not filled, ...) instead of "Detected", and harmonic
  trades at their target no longer read "Active stop".
- Ticker alerts: the buyer or seller with role and filing link, the
  trade and amount, traded and filed dates, and "Return in trade
  direction" with an (i) note (a line above the list on phones).
- Tablets keep the table with the time under the status; phones show
  each row as a card; tabs go two by two when a label can't fit.
- Summary queries count the tabs and feed the figures; the ticker alert
  archive filters by state, ticker and source.
- Assistant pages describe the new layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JanGradkowski
JanGradkowski enabled auto-merge (squash) November 12, 2026 10:23
@JanGradkowski
JanGradkowski merged commit e6da335 into main Nov 12, 2026
2 checks passed
@JanGradkowski
JanGradkowski deleted the signal-lists-design branch November 12, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants