Repository navigation
Give the signal lists the custom alert page's design - #52
Merged
Merged
Conversation
All signals (and a watchlist's), a stock's signals (/alerts/{id}) and All
ticker alerts now share the custom alert page's layout: a header with a
"How it works" guide, a figures band, tabs with counts, a ticker filter,
a sortable table, Select with bulk delete, keyboard shortcuts and a
pager. Filters, tabs and sorting stay links, so the server keeps paging
large archives.
- Figures from the whole filtered archive: items per day and, for
finished signals, how many ended higher, the median and a dot per
result (list-figures.js, shared with the custom alert page; unchanged
results are hollow dots). Too few results read as one line.
- Tabs All, Unread, Active and Completed (ticker alerts: All, Unread,
Purchases, Sales), a Types menu (ticker alerts: Source), an order list
at every width, and chips that remove one filter each.
- Status: the setup score sits beside the status word. Amber marks only
patterns waiting for confirmation, a solid dot what is still measured,
a ring what has finished; gains and losses are coloured on the result.
Finished Elliott and harmonic plans say how they ended (Target reached,
Stop breached, Not filled, ...) instead of "Detected", and harmonic
trades at their target no longer read "Active stop".
- Ticker alerts: the buyer or seller with role and filing link, the
trade and amount, traded and filed dates, and "Return in trade
direction" with an (i) note (a line above the list on phones).
- Tablets keep the table with the time under the status; phones show
each row as a card; tabs go two by two when a label can't fit.
- Summary queries count the tabs and feed the figures; the ticker alert
archive filters by state, ticker and source.
- Assistant pages describe the new layout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All signals (and a watchlist's), a stock's signals (
/alerts/{id}) and All ticker alerts now use the custom alert page's design:Filters, tabs and sorting stay links, so the server keeps paging large archives.
list-figures.js, shared with the custom alert page. Fewer than 5 results read as one line.Design review
An independent rater scored the pages from screenshots and the live review server: 6 → 6.5 → 7.5 → 8 → 8.5/10. Each round covered phone, tablet and desktop widths, both themes, and English and Polish. A layout check confirmed that nothing overlaps or overflows at 360, 390, 820 and 1440 px in either language.
Test plan
node --test src/test/js/*.test.cjs: 146 passed./mvnw -o test: 1134 run, 0 failures, 33 skippedArchiveLinksTestcovers the filter, sort and page URLs, andArchiveQueryRegressionIntegrationTestcovers the summary counts🤖 Generated with Claude Code